click

Merge lp:~mvo/click/remove-quiet into lp:click/devel

  1. remove-quiet
  2. Merge into devel
Proposed by Michael Vogt
Status: Rejected
Rejected by: Michael Vogt
Proposed branch: lp:~mvo/click/remove-quiet
Merge into: lp:click/devel
Diff against target: 25 lines (+0/-8)
1 file modified
lib/click/database.vala (+0/-8)
To merge this branch: bzr merge lp:~mvo/click/remove-quiet
Reviewer Review Type Date Requested Status
Colin Watson Needs Information
Review via email: mp+243652@code.launchpad.net

Description of the change

Do not show "Removing..." message on removal of a click

To post a comment you must log in.
Revision history for this message
Colin Watson (cjwatson) wrote :

Why's this?

review: Needs Information
Revision history for this message
Michael Vogt (mvo) wrote :

This was part of the snappy spec, but its no longer needed.

Unmerged revisions

547. By Michael Vogt

lib/click/database.vala: do not show "Removing ..." message on remove_unless_running

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'lib/click/database.vala'
2--- lib/click/database.vala 2014-09-12 11:46:05 +0000
3+++ lib/click/database.vala 2014-12-04 12:42:48 +0000
4@@ -94,12 +94,6 @@
5 Object (root: root, master_db: master_db);
6 }
7
8- private bool
9- show_messages ()
10- {
11- return Environment.get_variable ("TEST_QUIET") == null;
12- }
13-
14 /**
15 * get_path:
16 * @package: A package name.
17@@ -334,8 +328,6 @@
18 return;
19
20 var version_path = get_path (package, version);
21- if (show_messages ())
22- message ("Removing %s", version_path);
23 package_remove_hooks (master_db, package, version);
24 /* In Python, we used shutil.rmtree(version_path,
25 * ignore_errors=True), but GLib doesn't have an obvious

Subscribers

People subscribed via source and target branches

to all changes: