Merge lp:~mvo/click/lp1394256-run-user-hooks into lp:click/devel

[Michael Vogt]

This branch ensures that click user hooks are run for all logged in users when click is used with "--all-users".

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:549
No commit message was specified in the merge proposal. Click on the following link and set the commit message (if you want a jenkins rebuild you need to trigger it yourself):
https://code.launchpad.net/~mvo/click/lp1394256-run-user-hooks/+merge/242272/+edit-commit-message

http://jenkins.qa.ubuntu.com/job/click-devel-ci/121/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/click-devel-vivid-amd64-ci/5
    SUCCESS: http://jenkins.qa.ubuntu.com/job/click-devel-vivid-armhf-ci/5
        deb: http://jenkins.qa.ubuntu.com/job/click-devel-vivid-armhf-ci/5/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/click-devel-vivid-i386-ci/5

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/click-devel-ci/121/rebuild

review: Needs Fixing (continuous-integration)

[Colin Watson (cjwatson)]

review: Approve

=== modified file 'lib/click/user.vala'
--- lib/click/user.vala	2014-09-29 13:23:12 +0000
+++ lib/click/user.vala	2014-11-19 21:33:40 +0000
@@ -33,8 +33,21 @@
  * symlinks per user.
  */
 
+
 namespace Click {
 
+	struct LogindUser {
+		uint32 uid;
+		string name;
+		string ObjectPath;
+	}
+
+	/* the logind dbus interface */
+	[DBus (name = "org.freedesktop.login1.Manager")]
+	interface LogindManager : Object {
+		public abstract LogindUser[] ListUsers () throws IOError;
+	}
+
 /* Pseudo-usernames selected to be invalid as a real username, and alluding
  * to group syntaxes used in other systems.
  */
@@ -596,6 +609,35 @@
 		if (! is_pseudo_user)
 			package_install_hooks (db, package,
 					       old_version, version, name);
+
+		// run user hooks for all logged in users
+		if (name == ALL_USERS)
+			run_user_hooks_for_all_logged_in_users (package, old_version, version);
+	}
+
+	private void
+	run_user_hooks_for_all_logged_in_users (string package, string? old_version,
+											string version) throws IOError
+	{
+		try {
+			LogindManager logind = Bus.get_proxy_sync (
+				BusType.SYSTEM,
+				"org.freedesktop.login1",
+				"/org/freedesktop/login1");
+			var users = logind.ListUsers();
+			foreach (LogindUser user in users)
+			{
+				// FIXME: ideally we would read from /etc/adduser.conf
+				if(user.uid >= 1000 && user.uid <= 30000)
+				{
+					package_install_hooks (db, package,
+										   old_version, version, user.name);
+				}
+			}
+		} catch (Error e) {
+			warning ("Can not connect to logind");
+			return;
+		}
 	}
 
 	private bool