Merge lp:~mvngu/igraph/doc into lp:~igraph/igraph/0.6-main-old

Proposed by Minh Van Nguyen
Status: Merged
Merged at revision: 2647
Proposed branch: lp:~mvngu/igraph/doc
Merge into: lp:~igraph/igraph/0.6-main-old
Diff against target: 25 lines (+2/-2)
2 files modified
src/structural_properties.c (+1/-1)
src/type_indexededgelist.c (+1/-1)
To merge this branch: bzr merge lp:~mvngu/igraph/doc
Reviewer Review Type Date Requested Status
Gábor Csárdi Approve
Review via email: mp+95828@code.launchpad.net

Description of the change

Here is a description of the first patch. With trunk #2646, building the HTML version of the documentation resulted in the following error:

if [ "x.." != "x.." ]; then cp ../doc/fdl.xml ../doc/gpl.xml ../doc/installation.xml ../doc/introduction.xml ../doc/tutorial.xml ../doc/licenses.xml ../doc/pmt.xml . ; fi && \
 xmlto -x ../doc/gtk-doc.xsl -o html xhtml igraph-docs.xml \
 && touch html/stamp
xmlto: /home/mvngu/apps/igraph-hg/doc/igraph-docs.xml does not validate (status 3)
xmlto: Fix document syntax or use --skip-validation option
structural.xml:6982: element para: validity error : Element em is not declared in para list of possible children
structural.xml:6982: element para: validity error : Element em is not declared in para list of possible children
structural.xml:6983: element em: validity error : No declaration for element em
structural.xml:6983: element em: validity error : No declaration for element em
Document /home/mvngu/apps/igraph-hg/doc/igraph-docs.xml does not validate
make: *** [html/stamp] Error 13

This is due to using the HTML tag <em></em> in the documentation of the function igraph_linegraph(). A fix is to use doxygen's syntax for emphasizing words, i.e. the tag \em in doxygen.

Here is a description of the second patch. In the function igraph_get_eid(), the documentation for the parameter error is misleading. The current documentation for error implies that if error is set to false and the required edge is not found, then the function will return -1. This is clearly not the behaviour of the function. If the boolean error is set to false and the required edge is not found, then the parameter eid will be assigned value -1. My second patch makes this change in documentation.

To post a comment you must log in.
Revision history for this message
Gábor Csárdi (gabor.csardi) wrote :

All clean.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/structural_properties.c'
2--- src/structural_properties.c 2012-02-16 16:23:54 +0000
3+++ src/structural_properties.c 2012-03-05 02:31:18 +0000
4@@ -4696,7 +4696,7 @@
5 * is the same as the source of the second vertex's corresponding edge.
6 *
7 * </para><para>
8- * Edge <em>i</em> in the original graph will correspond to vertex <em>i</em>
9+ * Edge \em i in the original graph will correspond to vertex \em i
10 * in the line graph.
11 *
12 * </para><para>
13
14=== modified file 'src/type_indexededgelist.c'
15--- src/type_indexededgelist.c 2011-10-19 17:07:45 +0000
16+++ src/type_indexededgelist.c 2012-03-05 02:31:18 +0000
17@@ -1112,7 +1112,7 @@
18 * \param directed Logical constant, whether to search for directed
19 * edges in a directed graph. Ignored for undirected graphs.
20 * \param error Logical scalar, whether to report an error if the edge
21- * was not found. If it is false, then -1 is reported.
22+ * was not found. If it is false, then -1 will be assigned to \p eid.
23 * \return Error code.
24 * \sa \ref igraph_edge() for the opposite operation.
25 *

Subscribers

People subscribed via source and target branches