kstars-bleeding:user/akarsh/observinglist_batchadd_3

Last commit made on 2021-07-24
Get this branch:
git clone -b user/akarsh/observinglist_batchadd_3 https://git.launchpad.net/kstars-bleeding

Branch merges

Branch information

Name:
user/akarsh/observinglist_batchadd_3
Repository:
lp:kstars-bleeding

Recent commits

3222c0d... by Akarsh Simha <email address hidden>

Make CatalogsComponent::findByName return only exact matches

In KStars, we use SkyComponent::findByName in many places to get
objects (e.g. SkyComponent::findByName(i18n("Venus")) is a typical
pattern). In particular, some use-cases do the same with deep-sky
objects, but desire exact matches. For example, WUTDialog (What's up
tonight) and ObservingList (Observation Planner) both call
CatalogsComponent::findByName(...) to test if objects exist (otherwise
they should throw an error).

The present behavior tries to return prefix-matches instead of only
exact matches. This is desirable in FindDialog. It is not desirable in
these places that need exact matching and may silently alias one
object for another (eg: NGC 317 does not exist in OpenNGC because only
NGC 317A and NGC 317B are valid objects. Therefore, NGC 317 gets
silently aliased to NGC 3170).

However, CatalogsComponent::findByName is not used in FindDialog. This
patch proposes that CatalogsComponent::findByName ignore multiple
matches.

3946ca7... by Akarsh Simha <email address hidden>

[Needs Checking] Add documentation on the Batch Add feature

I've not been able to see the docs on my build of KStars. Going to
Help > KStars Handbook actually opens a Web URL in a browser. Is this
expected behavior? If it is, would someone be kind enough to review
this change and make sure it follows `doxygen` syntax?

cf6cc59... by Akarsh Simha <email address hidden>

"Batch add" option in the Observing List: add multiple objects (e.g. from a text file list) easily

Note: Requires CatalogComponent::findByName implementation from Merge
Request !87 (or alternatively !93) to work correctly. Might conflict
with !93, needing some changes to become compatible.

FEATURE:

0b41f79... by Akarsh Simha <email address hidden>

Refactor post-processing done in find dialog so it can be used independent of the dialog

41a085d... by l10n daemon script <email address hidden>

SVN_SILENT made messages (.desktop file) - always resolve ours

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

6123fa9... by Yuri Chornoivan <email address hidden>

Fix minor typos

0884643... by Jasem Mutlaq

Label KSPath test as unstable since it fails on CI

c3d580c... by Hy Murveit <email address hidden>

Refactor scheduler, use just one timer, add unit testing.

d101568... by Valentin Boettcher <email address hidden>

fix the object counts in the observation wizard

a3c2303... by Wolfgang Reissenberger <email address hidden>

Bugfix for guiding target plot showing mirrored plots