Divmod

Merge lp:~multani/divmod.org/remove-deprecated-twisted.python.reflect into lp:divmod.org

  1. remove-deprecated-twisted.python.reflect
  2. Merge into trunk
Proposed by Jonathan Ballet
Status: Merged
Approved by: Tristan Seligmann
Approved revision: 2715
Merged at revision: 2716
Proposed branch: lp:~multani/divmod.org/remove-deprecated-twisted.python.reflect
Merge into: lp:divmod.org
Diff against target: 12 lines (+1/-1)
1 file modified
Nevow/nevow/util.py (+1/-1)
To merge this branch: bzr merge lp:~multani/divmod.org/remove-deprecated-twisted.python.reflect
Reviewer Review Type Date Requested Status
Tristan Seligmann Approve
Glyph Lefkowitz Approve
Review via email: mp+182937@code.launchpad.net

Description of the change

This branch removes deprecated imports from twisted.python.reflect, which are going to be removed from Twisted sooner or later. Have a look at https://twistedmatrix.com/trac/ticket/6689

Those imports are not used in Nevow anyway.

To post a comment you must log in.
Revision history for this message
Glyph Lefkowitz (glyph) wrote :

Seems good to me. Tests pass. Might also be good to get rid of other imports in this file later, there are a ton of 'unused import' pyflakes warnings.

review: Approve
Revision history for this message
Tristan Seligmann (mithrandi) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'Nevow/nevow/util.py'
2--- Nevow/nevow/util.py 2007-08-02 19:40:41 +0000
3+++ Nevow/nevow/util.py 2013-08-29 16:02:12 +0000
4@@ -147,7 +147,7 @@
5 return 'utf-8'
6
7
8-from twisted.python.reflect import qual, namedAny, allYourBase, accumulateBases
9+from twisted.python.reflect import qual, namedAny
10 from twisted.python.util import uniquify
11
12 from twisted.internet.defer import Deferred, succeed, maybeDeferred, DeferredList

Subscribers

People subscribed via source and target branches

to all changes: