Merge lp:~muktupavels/unity-greeter/fix-flat-button into lp:unity-greeter

Proposed by Alberts Muktupāvels
Status: Merged
Merged at revision: 1455
Proposed branch: lp:~muktupavels/unity-greeter/fix-flat-button
Merge into: lp:unity-greeter
Diff against target: 16 lines (+3/-0)
1 file modified
src/flat-button.vala (+3/-0)
To merge this branch: bzr merge lp:~muktupavels/unity-greeter/fix-flat-button
Reviewer Review Type Date Requested Status
Robert Ancell Approve
Review via email: mp+243208@code.launchpad.net

Commit message

Last update introduced regression - flat buttons does nothing when clicked. Fix this by setting correct event type when calling button-press-event from button-release-event.

Description of the change

Last update introduced regression - flat buttons does nothing when clicked. Fix this by setting correct event type when calling button-press-event from button-release-event.

To post a comment you must log in.
1454. By Alberts Muktupāvels

Restore event type for button-release-event.

Revision history for this message
Robert Ancell (robert-ancell) wrote :

Thanks Alberts!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/flat-button.vala'
2--- src/flat-button.vala 2014-11-04 02:54:24 +0000
3+++ src/flat-button.vala 2014-11-29 12:14:29 +0000
4@@ -59,9 +59,12 @@
5 {
6 if (did_press)
7 {
8+ event.type = Gdk.EventType.BUTTON_PRESS;
9 base.button_press_event (event); // fake an insta-click
10 did_press = false;
11 }
12+
13+ event.type = Gdk.EventType.BUTTON_RELEASE;
14 return base.button_release_event (event);
15 }
16 }

Subscribers

People subscribed via source and target branches