Merge lp:~muktupavels/ubuntu-themes/lp1617415 into lp:ubuntu-themes

Proposed by Alberts Muktupāvels
Status: Merged
Approved by: Dmitry Shachnev
Approved revision: 501
Merged at revision: 506
Proposed branch: lp:~muktupavels/ubuntu-themes/lp1617415
Merge into: lp:ubuntu-themes
Diff against target: 29 lines (+12/-0)
2 files modified
Ambiance/gtk-3.20/gtk-widgets-borders.css (+6/-0)
Radiance/gtk-3.20/gtk-widgets-borders.css (+6/-0)
To merge this branch: bzr merge lp:~muktupavels/ubuntu-themes/lp1617415
Reviewer Review Type Date Requested Status
Dmitry Shachnev Approve
Iain Lane Pending
Ubuntu Artwork Packagers Pending
Review via email: mp+304238@code.launchpad.net

Commit message

Fix jumping menu items.

Description of the change

Fix jumping menu items (LP: #1617415).

To post a comment you must log in.
Revision history for this message
Dmitry Shachnev (mitya57) wrote :

For some reason, with this change I get red-ish border on menus in gnome-panel: http://people.ubuntu.com/~mitya57/tmp/red-border.png

review: Needs Fixing
Revision history for this message
Alberts Muktupāvels (muktupavels) wrote :

Does it work better now?

Revision history for this message
Iain Lane (laney) wrote :

Try making it "menu menuitem", so it doesn't apply to toplevel things

Revision history for this message
Alberts Muktupāvels (muktupavels) wrote :

> Try making it "menu menuitem", so it doesn't apply to toplevel things

But we need this fix also for toplevel things...

Revision history for this message
Iain Lane (laney) wrote :

On Mon, Aug 29, 2016 at 11:10:48AM -0000, Alberts Muktupāvels wrote:
> > Try making it "menu menuitem", so it doesn't apply to toplevel things
>
> But we need this fix also for toplevel things...

Ok, I didn't notice that it was a problem there. Then I think that
either setting a color or a width should help you.

--
Iain Lane [ <email address hidden> ]
Debian Developer [ <email address hidden> ]
Ubuntu Developer [ <email address hidden> ]

Revision history for this message
Dmitry Shachnev (mitya57) wrote :

r502 works fine, and the bug is fixed. Thanks!

review: Approve
Revision history for this message
Iain Lane (laney) wrote :

On Mon, Aug 29, 2016 at 11:29:00AM -0000, Dmitry Shachnev wrote:
> Review: Approve
>
> r502 works fine, and the bug is fixed. Thanks!

If you tested in Unity (global menubar and in-app menus), then approve
and add to the ongoing landing please.

--
Iain Lane [ <email address hidden> ]
Debian Developer [ <email address hidden> ]
Ubuntu Developer [ <email address hidden> ]

Revision history for this message
Iain Lane (laney) wrote :

On Mon, Aug 29, 2016 at 11:33:21AM -0000, Iain Lane wrote:
> On Mon, Aug 29, 2016 at 11:29:00AM -0000, Dmitry Shachnev wrote:
> > Review: Approve
> >
> > r502 works fine, and the bug is fixed. Thanks!
>
> If you tested in Unity (global menubar and in-app menus), then approve
> and add to the ongoing landing please.

Looks like Marco already uploaded that one, so feel free to start a new
one.

(And thanks!)

--
Iain Lane [ <email address hidden> ]
Debian Developer [ <email address hidden> ]
Ubuntu Developer [ <email address hidden> ]

501. By Alberts Muktupāvels

Fix jumping menu items.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'Ambiance/gtk-3.20/gtk-widgets-borders.css'
--- Ambiance/gtk-3.20/gtk-widgets-borders.css 2016-08-01 12:10:11 +0000
+++ Ambiance/gtk-3.20/gtk-widgets-borders.css 2016-08-29 11:55:54 +0000
@@ -1,4 +1,10 @@
1/* Borders */1/* Borders */
2menubar menuitem,
3.menubar.menuitem {
4 border: 1px solid transparent;
5 border-bottom-width: 0px;
6}
7
2menubar menuitem:hover,8menubar menuitem:hover,
3.menubar.menuitem:hover {9.menubar.menuitem:hover {
4 border: 1px solid #2e2e2c;10 border: 1px solid #2e2e2c;
511
=== modified file 'Radiance/gtk-3.20/gtk-widgets-borders.css'
--- Radiance/gtk-3.20/gtk-widgets-borders.css 2016-08-04 16:31:00 +0000
+++ Radiance/gtk-3.20/gtk-widgets-borders.css 2016-08-29 11:55:54 +0000
@@ -1,4 +1,10 @@
1/* Borders */1/* Borders */
2menubar menuitem,
3.menubar.menuitem {
4 border: 1px solid transparent;
5 border-bottom-width: 0px;
6}
7
2menubar menuitem:hover,8menubar menuitem:hover,
3.menubar.menuitem:hover {9.menubar.menuitem:hover {
4 border: 1px solid #2e2e2c;10 border: 1px solid #2e2e2c;

Subscribers

People subscribed via source and target branches