Merge lp:~muktupavels/ubuntu-themes/background-remove-box-shadow into lp:ubuntu-themes

Proposed by Alberts Muktupāvels
Status: Merged
Approved by: Iain Lane
Approved revision: no longer in the source branch.
Merged at revision: 505
Proposed branch: lp:~muktupavels/ubuntu-themes/background-remove-box-shadow
Merge into: lp:ubuntu-themes
Diff against target: 25 lines (+10/-0)
2 files modified
Ambiance/gtk-3.20/apps/nautilus.css (+5/-0)
Radiance/gtk-3.20/apps/nautilus.css (+5/-0)
To merge this branch: bzr merge lp:~muktupavels/ubuntu-themes/background-remove-box-shadow
Reviewer Review Type Date Requested Status
Dmitry Shachnev Approve
Iain Lane Approve
Ubuntu Artwork Packagers Pending
Review via email: mp+304117@code.launchpad.net

Commit message

Remove box-shadow from .background:backdrop.

Description of the change

Remove box-shadow from .background:backdrop. Because of this I see border on nautilus desktop window when it is not focused. Same things happens in guest session with Unity.

To post a comment you must log in.
Revision history for this message
Dmitry Shachnev (mitya57) wrote :

I can confirm that the bug exists (on Unity) and that this proposal fixes it.

review: Approve
Revision history for this message
Iain Lane (laney) wrote :

I think it was meant to draw shadows on toplevel windows when they are in the background - can you confirm that this still looks right (assume xenial was correct) with your change?

review: Needs Information
Revision history for this message
Dmitry Shachnev (mitya57) wrote :

> I think it was meant to draw shadows on toplevel windows when they are in the background

I don't see any difference with this change. Inactive windows still have their (tiny) shadows.

Revision history for this message
Iain Lane (laney) wrote :

ok, thanks!

review: Approve
Revision history for this message
Alberts Muktupāvels (muktupavels) wrote :

Then maybe it might be better to do this (I don't want to introduce regressions):
nautilus-desktop-window:backdrop,
.nautilus-desktop-window:backdrop {
    box-shadow: none;
}

Revision history for this message
Dmitry Shachnev (mitya57) wrote :

nautilus-desktop-window is only a node name, not a CSS class. Why do you need the second lines (starting with .)?

Revision history for this message
Alberts Muktupāvels (muktupavels) wrote :

In 3.20 nautilus desktop window has nautilus-desktop-window css node. In 3.22 it was replaced with css class. Using both we make sure that theme will work with both versions. :)

Revision history for this message
Dmitry Shachnev (mitya57) wrote :

Also for me r503 does not work — still the white border :(

review: Needs Fixing
501. By Alberts Muktupāvels

Remove box-shadow from nautilus desktop window.

Revision history for this message
Alberts Muktupāvels (muktupavels) wrote :

Now it should work. :)

Revision history for this message
Dmitry Shachnev (mitya57) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'Ambiance/gtk-3.20/apps/nautilus.css'
2--- Ambiance/gtk-3.20/apps/nautilus.css 2016-08-01 12:10:11 +0000
3+++ Ambiance/gtk-3.20/apps/nautilus.css 2016-08-29 11:53:51 +0000
4@@ -1,3 +1,8 @@
5+nautilus-desktop-window.background:backdrop,
6+.nautilus-desktop-window.background:backdrop {
7+ box-shadow: none;
8+}
9+
10 .nautilus-canvas-item {
11 border-radius: 5px;
12 }
13
14=== modified file 'Radiance/gtk-3.20/apps/nautilus.css'
15--- Radiance/gtk-3.20/apps/nautilus.css 2016-08-04 16:31:00 +0000
16+++ Radiance/gtk-3.20/apps/nautilus.css 2016-08-29 11:53:51 +0000
17@@ -1,3 +1,8 @@
18+nautilus-desktop-window.background:backdrop,
19+.nautilus-desktop-window.background:backdrop {
20+ box-shadow: none;
21+}
22+
23 .nautilus-canvas-item {
24 border-radius: 5px;
25 }

Subscribers

People subscribed via source and target branches