~muktupavels/libgnome-volume-control/+git/libgnome-volume-control:gbsneto/unnecessary-warnings

Branch merges

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related charm recipes

2a7a100... by Georges Basile Stavracas Neto on 2019-06-16

mixer-control: Remove unnecessary instance checks

gvc_mixer_control_get_vol_max_norm() and gvc_mixer_control_get_vol_max_amplified()
do not access any of the instance variables. In GNOME Settings, we even
pass NULL to these functions. So checking the instance is not necessary.

In fact, this is causing instance check failures in GNOME Settings, and
the entire Sound panel is broken since those functions are returning zero.

The reason that only the checks are being dropped, and not the parameter
entirely, is to preserve API compatibility.

468022b... by Georges Basile Stavracas Neto on 2019-06-14

mixer-control: Use the "emblem-system-symbolic" icon

As suggested by the last round of design review [1], use the
"emblem-system-symbolic" icon with system sounds.

[1] https://gitlab.gnome.org/GNOME/gnome-control-center/issues/548

3f45745... by Robert Ancell on 2019-03-14

Add missing guards for inputs to functions

b28ae07... by Robert Ancell on 2019-03-14

Add missing allow-none annotations

0e1b4bd... by Bastien Nocera on 2019-02-27

ci: Add CI

This just builds the "what-did-you-plugin" test application, but it's
good enough to catch the worst failures.

ae1a34a... by Andre Klapper on 2018-12-16

Comment invalid <category> in DOAP file to pass git pre-receive hook

3513d37... by Guido Günther on 2018-12-07

gvc-mixer-ui-device: Trim additional newlines in debug output

GVC logs a lot aready. No need to make it consume more screen space
with additional newlines.

7de39e7... by Bastien Nocera on 2018-09-10

Merge branch 'wip/muktupavels/warnings' into 'master'

Fix build warnings

See merge request GNOME/libgnome-volume-control!2

4e9205d... by Alberts Muktupāvels on 2018-09-08

fix cast-function-type warnings

gvc-mixer-card.c: In function ‘gvc_mixer_card_finalize’:
gvc-mixer-card.c:571:53: warning: cast between incompatible function types from ‘void (*)(GvcMixerCardProfile *)’ {aka ‘void (*)(struct <anonymous> *)’} to ‘void (*)(void *, void *)’ [-Wcast-function-type]
         g_list_foreach (mixer_card->priv->profiles, (GFunc) free_profile, NULL);

gvc-mixer-stream.c: In function ‘gvc_mixer_stream_finalize’:
gvc-mixer-stream.c:1044:52: warning: cast between incompatible function types from ‘void (*)(GvcMixerStreamPort *)’ {aka ‘void (*)(struct <anonymous> *)’} to ‘void (*)(void *, void *)’ [-Wcast-function-type]
         g_list_foreach (mixer_stream->priv->ports, (GFunc) free_port, NULL);

13a4a9a... by Alberts Muktupāvels on 2018-09-08

avoid deprecated g_type_class_add_private