lp:~muktupavels/indicator-sound/indicator-sound

Branch merges

Propose for merging

No branches dependent on this one.

Approved for merging into lp:indicator-sound

Indicator Applet Developers: Pending requested 2022-10-10

Diff: 156 lines (+34/-27)

7 files modified

CMakeLists.txt (+1/-1)
src/accounts-service-user.vala (+6/-2)
src/media-player-list-mpris.vala (+3/-0)
tests/dbus-types/CMakeLists.txt (+3/-3)
tests/integration/CMakeLists.txt (+12/-12)
tests/service-mocks/accounts-mock/CMakeLists.txt (+3/-3)
tests/service-mocks/media-player-mpris-mock/CMakeLists.txt (+6/-6)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Related blueprints

570. By Alberts Muktupāvels on 2022-10-10

media-player-list-mpris: fix critical

indicator-sound-CRITICAL:
media_player_list_mpris_insert: assertion 'desktop_id != NULL' failed

Warning can be reproduced watching YouTube video in Google Chrome.

569. By Alberts Muktupāvels on 2022-10-10

accounts-service-user: fix warnings

warning: Access to possible `null'. Perform a check or use an unsafe cast.

568. By Alberts Muktupāvels on 2022-10-10

cmake: bump minimum required version to 3.18.0

Fixes following warning:
CMake Deprecation Warning at CMakeLists.txt:2 (cmake_minimum_required):
  Compatibility with CMake < 2.8.12 will be removed from a future version of
  CMake.

567. By Alberts Muktupāvels on 2022-10-10

tests: stop using qt5_use_modules

Fixes following warnings:
CMake Warning (dev) at /usr/lib/x86_64-linux-gnu/cmake/Qt5Core/Qt5CoreMacros.cmake:44 (message):
  qt5_use_modules is not part of the official API, and might be removed in Qt 6.

566. By Gunnar Hjalmarsson on 2021-09-29

d/changelog tweaks + upload to impish

565. By Khurshid Alam on 2021-09-29

* Fix build against vala > 48 & vala >= 50
* Add symbolic icons to the tests
* Avoid possible null value in Greeterlist and GreeterBroadcast object.
  See https://github.com/AyatanaIndicators/ayatana-indicator-sound/commit/8df9168f5587cfd31e0bf6a4170a4c4f9784dbb7
* Fix build against GLib > 2.64: Replace HashTable with GenericSet
* Fix static member access
* Drop deprecated DBusProxy.create_for_bus
* Add libdbustest-1 include path
* Unit Tests: Unset environment variable and session bus in teardown
* debian/control: Remove qt5-default & add libgmock-dev in build depends. See https://bugs.launchpad.net/bugs/1921781
* Unit Tests: The desktop pulseaudio daemon also needs the stream-restore module these days
* Unit Tests: Disable notification tests that can not be fixed now. Most of them are phone related and depends on liburl-dispatcher library which was dropped from code since it is no longer in the universe repository. See https://bazaar.launchpad.net/~indicator-applet-developers/indicator-sound/trunk.16.10/revision/564
* Unit Tests: Disable indicator tests that can not be fixed now. These tests needs to be re-enabled later
 - tests/indicator-test.cc:PhoneMenu
 - tests/indicator-test.cc:DesktopMenu
 - tests/indicator-test.cc:BaseActions
 - tests/integration/test-indicator.cpp:All tests
 - tests/volume-control-test.cc:BasicObject
* debian/rules: Re enable live tests logs

564. By Dimitri John Ledkov on 2020-06-04

* Drop url-dispatcher based Unity8 support. ubuntu-app-launch &
  url-dispatcher fail to build from source and are now holding up
  transitions in groovy. Unity8 has been removed from the Ubuntu
  Archive. This can be reintroduced back, if ubuntu-app-launch /
  url-dispatcher (or equivalent) are fixed to not FTBFS with new glib.
* Run, but ignore failing tests. It seems like expectations around theme
  icons have changed, and connection to pulseaudio again is failing to
  be setup. Mostly affecting integration tests. Also dbus mocks for
  AccountsService are not shut down, resulting in builds hanging. Thus
  wrap running tests in a timeout of at most 10minutes.

563. By Sebastien Bacher on 2020-04-03

releasing package indicator-sound version 12.10.2+18.10.20180612-0ubuntu2

562. By Marco Trevisan (Treviño) on 2018-04-20

tests, integration: set environment variables to work headless (LP: #1737834)

561. By Sebastien Bacher on 2018-04-03

releasing package indicator-sound version 12.10.2+17.10.20170829.1-0ubuntu2