Merge lp:~muktupavels/compiz/star-imports into lp:compiz/0.9.13

Proposed by Alberts Muktupāvels
Status: Merged
Approved by: Dmitry Shachnev
Approved revision: 4162
Merged at revision: 4165
Proposed branch: lp:~muktupavels/compiz/star-imports
Merge into: lp:compiz/0.9.13
Diff against target: 138 lines (+27/-26)
6 files modified
compizconfig/ccsm/ccm/Conflicts.py (+2/-2)
compizconfig/ccsm/ccm/Pages.py (+9/-5)
compizconfig/ccsm/ccm/Settings.py (+8/-8)
compizconfig/ccsm/ccm/Utils.py (+1/-4)
compizconfig/ccsm/ccm/Widgets.py (+5/-3)
compizconfig/ccsm/ccm/Window.py (+2/-4)
To merge this branch: bzr merge lp:~muktupavels/compiz/star-imports
Reviewer Review Type Date Requested Status
Marco Trevisan (Treviño) Approve
Dmitry Shachnev Approve
Review via email: mp+349663@code.launchpad.net

Commit message

ccsm: don't use star imports.

Description of the change

Don't use star imports.

To post a comment you must log in.
lp:~muktupavels/compiz/star-imports updated
4162. By Alberts Muktupāvels

Remove unused variable.

Revision history for this message
Dmitry Shachnev (mitya57) :
review: Approve
Revision history for this message
Marco Trevisan (Treviño) (3v1n0) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'compizconfig/ccsm/ccm/Conflicts.py'
2--- compizconfig/ccsm/ccm/Conflicts.py 2018-07-11 21:59:31 +0000
3+++ compizconfig/ccsm/ccm/Conflicts.py 2018-07-16 23:49:21 +0000
4@@ -22,8 +22,8 @@
5
6 from gi.repository import Gtk
7
8-from ccm.Constants import *
9-from ccm.Utils import *
10+from ccm.Constants import DataDir
11+from ccm.Utils import protect_markup_dict, GetSettings
12
13 import locale
14 import gettext
15
16=== modified file 'compizconfig/ccsm/ccm/Pages.py'
17--- compizconfig/ccsm/ccm/Pages.py 2018-07-12 14:25:13 +0000
18+++ compizconfig/ccsm/ccm/Pages.py 2018-07-16 23:49:21 +0000
19@@ -26,11 +26,15 @@
20 import compizconfig
21 ccs = compizconfig
22
23-from ccm.Constants import *
24-from ccm.Settings import *
25-from ccm.Conflicts import *
26-from ccm.Utils import *
27-from ccm.Widgets import *
28+from ccm.Constants import CurrentScreenNum, KeyModifier, HeaderMarkup, ImagePlugin, ImageCategory, ImageStock, FilterName, FilterLongDesc, FilterValue, FilterCategory, FilterAll, DataDir
29+from ccm.Settings import BaseListSetting, SubGroupArea
30+from ccm.Conflicts import PluginConflict
31+from ccm.Utils import gtk_process_events, getScreens, Image, PrettyButton, Label, NotFoundBox, GlobalUpdater, CategoryKeyFunc, GroupIndexKeyFunc, PluginKeyFunc, GetSettings, GetAcceleratorName
32+from ccm.Widgets import ClearEntry, PluginView, GroupView, SelectorButtons, ScrolledList, Popup, KeyGrabber, AboutDialog, PluginWindow
33+
34+from cgi import escape as protect_pango_markup
35+
36+import os
37
38 import locale
39 import gettext
40
41=== modified file 'compizconfig/ccsm/ccm/Settings.py'
42--- compizconfig/ccsm/ccm/Settings.py 2018-07-12 14:25:13 +0000
43+++ compizconfig/ccsm/ccm/Settings.py 2018-07-16 23:49:21 +0000
44@@ -22,13 +22,13 @@
45
46 from gi.repository import Gtk
47 from gi.repository import Gdk
48-import os
49-
50-from ccm.Constants import *
51-from ccm.Conflicts import *
52-from ccm.Widgets import *
53-from ccm.Utils import *
54-from ccm.Pages import *
55+
56+from ccm.Constants import TableDef, TableX, KeyModifier, Edges, ImageStock, FilterName, FilterLongDesc, FilterValue, FilterAll, DataDir
57+from ccm.Conflicts import KeyConflict, ButtonConflict, EdgeConflict
58+from ccm.Widgets import CellRendererColor, ModifierSelector, SingleEdgeSelector, KeyGrabber, MatchButton, FileButton, ErrorDialog, WarningDialog
59+from ccm.Utils import Image, ActionImage, SizedButton, GlobalUpdater, PureVirtualError, SettingKeyFunc, EnumSettingKeyFunc, HasOnlyType, GetSettings, GetAcceleratorName
60+
61+from cgi import escape as protect_pango_markup
62
63 import locale
64 import gettext
65@@ -661,7 +661,7 @@
66
67 self.EditDialogOpen = True
68 self.EditDialog.show_all()
69- response = self.EditDialog.run()
70+ self.EditDialog.run()
71 self.EditDialog.hide()
72 self.EditDialogOpen = False
73
74
75=== modified file 'compizconfig/ccsm/ccm/Utils.py'
76--- compizconfig/ccsm/ccm/Utils.py 2018-07-12 14:25:13 +0000
77+++ compizconfig/ccsm/ccm/Utils.py 2018-07-16 23:49:21 +0000
78@@ -20,17 +20,14 @@
79 # Christopher Williams (christopherw@verizon.net)
80 # Copyright (C) 2007 Quinn Storm
81
82-import os
83-
84 from gi.repository import Gtk
85 from gi.repository import Gdk
86 from gi.repository import GObject
87 import weakref
88
89-from ccm.Constants import *
90+from ccm.Constants import ImageNone, ImagePlugin, ImageCategory, ImageThemed, ImageStock, DataDir, IconDir
91 from cgi import escape as protect_pango_markup
92 import operator
93-import itertools
94
95 import locale
96 import gettext
97
98=== modified file 'compizconfig/ccsm/ccm/Widgets.py'
99--- compizconfig/ccsm/ccm/Widgets.py 2018-07-12 14:41:42 +0000
100+++ compizconfig/ccsm/ccm/Widgets.py 2018-07-16 23:49:21 +0000
101@@ -26,15 +26,17 @@
102 from gi.repository import PangoCairo
103 from gi.repository import GdkPixbuf
104 import cairo
105+from cgi import escape as protect_pango_markup
106 from math import pi, sqrt
107 import time
108+import os
109 import re
110 import mimetypes
111 mimetypes.init()
112
113-from ccm.Utils import *
114-from ccm.Constants import *
115-from ccm.Conflicts import *
116+from ccm.Utils import IconTheme, gtk_process_events, Image, PrettyButton, Label, NotFoundBox, GlobalUpdater, PluginSetting, SettingKeyFunc, CategoryKeyFunc, PluginKeyFunc, GetSettings, GetAcceleratorName
117+from ccm.Constants import TableX, TableY, ImagePlugin, ImageCategory, ImageStock, FilterName, FilterLongDesc, FilterCategory, FilterAll, DataDir, PixmapDir, ConfDir, ConfFile, Version
118+from ccm.Conflicts import EdgeConflict, FeatureRequirement, PluginConflict
119
120 import locale
121 import gettext
122
123=== modified file 'compizconfig/ccsm/ccm/Window.py'
124--- compizconfig/ccsm/ccm/Window.py 2018-07-12 14:25:13 +0000
125+++ compizconfig/ccsm/ccm/Window.py 2018-07-16 23:49:21 +0000
126@@ -22,10 +22,8 @@
127
128 from gi.repository import Gtk
129
130-from ccm.Pages import *
131-from ccm.Utils import *
132-from ccm.Constants import *
133-from ccm.Conflicts import *
134+from ccm.Pages import PluginPage, MainPage
135+from ccm.Constants import DataDir
136
137 import locale
138 import gettext

Subscribers

People subscribed via source and target branches