Code review comment for lp:~muktupavels/compiz/pygobject-warnings

Revision history for this message
Dmitry Shachnev (mitya57) wrote :

For future, it is better to remove whitespace when passing function arguments.
Quoting from https://www.python.org/dev/peps/pep-0008/#other-recommendations:

Yes:

def complex(real, imag=0.0):
    return magic(r=real, i=imag)

No:

def complex(real, imag = 0.0):
    return magic(r = real, i = imag)

Anyway approving because it is not related to your fixes.

review: Approve

« Back to merge proposal