Merge lp:~muktupavels/compiz/protobuf into lp:compiz/0.9.13

Proposed by Alberts Muktupāvels on 2019-02-06
Status: Merged
Approved by: Dmitry Shachnev on 2019-02-07
Approved revision: 4203
Merged at revision: 4205
Proposed branch: lp:~muktupavels/compiz/protobuf
Merge into: lp:compiz/0.9.13
Diff against target: 14 lines (+2/-1)
1 file modified
compizconfig/libcompizconfig/src/compizconfig.proto (+2/-1)
To merge this branch: bzr merge lp:~muktupavels/compiz/protobuf
Reviewer Review Type Date Requested Status
Dmitry Shachnev 2019-02-06 Approve on 2019-02-07
Review via email: mp+362826@code.launchpad.net

Commit message

Fix protobuf warning by explicitly specifying proto2 syntax.

Description of the change

[libprotobuf WARNING google/protobuf/compiler/parser.cc:562] No syntax specified for the proto file: compizconfig.proto. Please use 'syntax = "proto2";' or 'syntax = "proto3";' to specify a syntax version. (Defaulted to proto2 syntax.)

To post a comment you must log in.
Dmitry Shachnev (mitya57) wrote :

I think double blank lines for separating toplevel messages were useful, but approving anyway.

review: Approve
lp:~muktupavels/compiz/protobuf updated on 2019-02-07
4203. By Alberts Muktupāvels on 2019-02-07

Fix "No syntax specified for the proto file" warning by setting syntax to proto2.

Alberts Muktupāvels (muktupavels) wrote :

I decided to stick with proto2 syntax. We can upgrade to proto3 later...

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'compizconfig/libcompizconfig/src/compizconfig.proto'
2--- compizconfig/libcompizconfig/src/compizconfig.proto 2009-03-14 19:53:55 +0000
3+++ compizconfig/libcompizconfig/src/compizconfig.proto 2019-02-07 13:47:03 +0000
4@@ -1,3 +1,5 @@
5+syntax="proto2";
6+
7 package metadata;
8
9 option optimize_for = SPEED;
10@@ -160,4 +162,3 @@
11
12 repeated Extension extension = 3;
13 }
14-

Subscribers

People subscribed via source and target branches