Merge lp:~muktupavels/compiz/gnome into lp:compiz/0.9.13

Proposed by Alberts Muktupāvels
Status: Merged
Approved by: Dmitry Shachnev
Approved revision: 4195
Merged at revision: 4198
Proposed branch: lp:~muktupavels/compiz/gnome
Merge into: lp:compiz/0.9.13
Diff against target: 95 lines (+7/-37)
4 files modified
debian/compiz-gnome.install (+0/-1)
debian/rules (+0/-4)
gtk/CMakeLists.txt (+0/-21)
gtk/gnome/CMakeLists.txt (+7/-11)
To merge this branch: bzr merge lp:~muktupavels/compiz/gnome
Reviewer Review Type Date Requested Status
Dmitry Shachnev Approve
Review via email: mp+362707@code.launchpad.net

Commit message

Fix GNOME building.

Description of the change

This change gives nice green Yes in cmake configure output.

To post a comment you must log in.
Revision history for this message
Dmitry Shachnev (mitya57) wrote :

LGTM, let’s include this in the next upload.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/compiz-gnome.install'
2--- debian/compiz-gnome.install 2016-07-04 10:12:34 +0000
3+++ debian/compiz-gnome.install 2019-02-05 01:42:37 +0000
4@@ -5,6 +5,5 @@
5 usr/bin/gtk-window-decorator
6 usr/lib/*/compizconfig/backends/libgsettings.so
7 usr/lib/*/libcompizconfig_gsettings_backend.so
8-usr/share/applications/compiz.desktop usr/share/gnome/wm-properties/
9 usr/share/glib-2.0/schemas/*.xml
10 usr/share/gnome-control-center
11
12=== modified file 'debian/rules'
13--- debian/rules 2019-01-03 18:56:07 +0000
14+++ debian/rules 2019-02-05 01:42:37 +0000
15@@ -51,10 +51,6 @@
16 # remove acceptance test binary
17 rm -f debian/tmp/usr/bin/compiz_autopilot_acceptance_tests
18
19- # ugly hack to install xml files
20- mkdir -p debian/tmp/usr/share/gnome-control-center/keybindings
21- find */gtk/gnome -name *.xml | xargs cp -at debian/tmp/usr/share/gnome-control-center/keybindings/
22-
23 # work around having a file with a conflicted special name (#1156294)
24 cp debian/compizconfig debian/tmp/config
25
26
27=== modified file 'gtk/CMakeLists.txt'
28--- gtk/CMakeLists.txt 2017-04-25 08:13:36 +0000
29+++ gtk/CMakeLists.txt 2019-02-05 01:42:37 +0000
30@@ -37,27 +37,6 @@
31 endif (LIBMETACITY_FOUND)
32 endif (USE_METACITY)
33
34- if (USE_GNOME)
35- compiz_pkg_check_modules (GNOME_WINDOW_SETTINGS
36- gnome-window-settings-2.0
37- gnome-desktop-2.0
38- )
39-
40- if (GNOME_WINDOW_SETTINGS_FOUND)
41- exec_program (${PKG_CONFIG_EXECUTABLE}
42- ARGS "--variable=prefix gnome-window-settings-2.0"
43- OUTPUT_VARIABLE windowsettingsdatadir
44- )
45- set (windowsettingsdatadir ${windowsettingsdatadir}/share)
46- exec_program (${PKG_CONFIG_EXECUTABLE}
47- ARGS "--variable=libdir gnome-window-settings-2.0"
48- OUTPUT_VARIABLE windowsettingslibdir
49- )
50- else (GNOME_WINDOW_SETTINGS_FOUND)
51- compiz_set (USE_GNOME 0)
52- endif (GNOME_WINDOW_SETTINGS_FOUND)
53- endif (USE_GNOME)
54-
55 else (GTK_WINDOW_DECORATOR_FOUND)
56 compiz_set (USE_GTK 0)
57 endif (GTK_WINDOW_DECORATOR_FOUND)
58
59=== modified file 'gtk/gnome/CMakeLists.txt'
60--- gtk/gnome/CMakeLists.txt 2012-12-05 13:26:30 +0000
61+++ gtk/gnome/CMakeLists.txt 2019-02-05 01:42:37 +0000
62@@ -10,27 +10,23 @@
63 )
64
65 set (_keybindings_files
66- 50-compiz-navigation.xml.in
67- 50-compiz-windows.xml.in)
68+ 50-compiz-navigation.xml
69+ 50-compiz-windows.xml)
70
71 set (_keybindings_files_translated "")
72
73 foreach (_keybinding_file ${_keybindings_files})
74- string (LENGTH ${_keybinding_file} _str_len)
75- math (EXPR _str_len_no_in "${_str_len} - 3")
76- string (SUBSTRING ${_keybinding_file} 0 ${_str_len_no_in} _keybinding_file_no_in)
77-
78- compiz_translate_xml (${CMAKE_CURRENT_SOURCE_DIR}/${_keybinding_file}
79- ${CMAKE_CURRENT_BINARY_DIR}/${_keybinding_file_no_in} NOTRANSLATIONS)
80-
81- list (APPEND _keybindings_files_translated ${CMAKE_CURRENT_BINARY_DIR}/${_keybinding_file_no_in})
82+ compiz_translate_xml (${CMAKE_CURRENT_SOURCE_DIR}/${_keybinding_file}.in
83+ ${CMAKE_CURRENT_BINARY_DIR}/${_keybinding_file} NOTRANSLATIONS)
84+
85+ list (APPEND _keybindings_files_translated ${CMAKE_CURRENT_BINARY_DIR}/${_keybinding_file})
86 endforeach (_keybinding_file ${keybinding_files})
87
88 add_custom_target (compiz-gnome-keybindings ALL DEPENDS
89 ${_keybindings_files_translated})
90
91 install (
92- FILES ${_keybinding_files_translated}
93+ FILES ${_keybindings_files_translated}
94 DESTINATION ${datadir}/gnome-control-center/keybindings
95 )
96

Subscribers

People subscribed via source and target branches