Merge lp:~muktupavels/compiz/gcc-8.1 into lp:compiz/0.9.13

[Alberts Muktupāvels]

Fix build errors with GCC 8.1.

Fix build errors with GCC 8.1.

Revision 4061 added back animationaddon plugin by porting to modern GL API. It changed colors and dcolors from GLfloat to GLushort, but did not update colorSize...

[lp:~muktupavels/compiz/gcc-8.1]

4172. By Alberts Muktupāvels on 2018-07-18

Fix -Wclass-memaccess errors in wall plugin.

[Dmitry Shachnev (mitya57)]

review: Approve

[Marco Trevisan (Treviño) (3v1n0)]

review: Needs Fixing

[Alberts Muktupāvels (muktupavels)]

Done.

[lp:~muktupavels/compiz/gcc-8.1]

4173. By Alberts Muktupāvels on 2018-07-23

Add constructor for WallCairoContext.

[Marco Trevisan (Treviño) (3v1n0)]

Thanks

review: Approve

=== modified file 'plugins/animationaddon/src/particle.cpp'
--- plugins/animationaddon/src/particle.cpp	2018-02-21 17:29:21 +0000
+++ plugins/animationaddon/src/particle.cpp	2018-07-23 14:14:34 +0000
@@ -117,7 +117,7 @@
     GLushort *colors = &mColorsCache[0];
 
     int cornersSize = sizeof (GLfloat) * 12;
-    int colorSize = sizeof (GLfloat) * 4;
+    int colorSize = sizeof (GLushort) * 4;
 
     GLfloat cornerCoords[12] = {0.0, 0.0,
 			       0.0, 1.0,

=== modified file 'plugins/decor/src/decor.cpp'
--- plugins/decor/src/decor.cpp	2018-02-21 17:29:21 +0000
+++ plugins/decor/src/decor.cpp	2018-07-23 14:14:34 +0000
@@ -1649,8 +1649,7 @@
 	    if (!wd)
 	    {
 		/* Error condition, reset frame extents */
-		CompWindowExtents emptyExtents;
-		memset (&emptyExtents, 0, sizeof (CompWindowExtents));
+		CompWindowExtents emptyExtents = CompWindowExtents ();
 		window->setWindowFrameExtents (&emptyExtents, &emptyExtents);
 		return false;
 	    }
@@ -1671,7 +1670,7 @@
     }
     else
     {
-	CompWindowExtents emptyExtents;
+	CompWindowExtents emptyExtents = CompWindowExtents ();
 
 	if (wd)
 	{
@@ -1681,7 +1680,6 @@
 
 	/* _NET_FRAME_EXTENTS should be updated before the frame
 	 * atom is */
-	memset (&emptyExtents, 0, sizeof (CompWindowExtents));
 
 	window->setWindowFrameExtents (&emptyExtents, &emptyExtents);
 

=== modified file 'plugins/imgsvg/src/imgsvg.cpp'
--- plugins/imgsvg/src/imgsvg.cpp	2018-02-21 17:29:21 +0000
+++ plugins/imgsvg/src/imgsvg.cpp	2018-07-23 14:14:34 +0000
@@ -327,7 +327,7 @@
 		finiTexture (context->texture[1]);
 		initTexture (source, context->texture[1], CompSize ());
 
-		memset (&context->rect, 0, sizeof (BoxRec));
+		context->rect = CompRect ();
 		context->size.setWidth (0);
 		context->size.setHeight (0);
 	    }

=== modified file 'plugins/wall/src/wall.cpp'
--- plugins/wall/src/wall.cpp	2013-10-30 19:03:53 +0000
+++ plugins/wall/src/wall.cpp	2018-07-23 14:14:34 +0000
@@ -53,6 +53,16 @@
 
 COMPIZ_PLUGIN_20090315 (wall, WallPluginVTable);
 
+WallCairoContext::WallCairoContext () :
+    pixmap (0),
+    texture (0),
+    surface (NULL),
+    cr (NULL),
+    width (0),
+    height (0)
+{
+}
+
 void
 WallScreen::clearCairoLayer (cairo_t *cr)
 {
@@ -1646,10 +1656,6 @@
     // to prevent crashes in XCloseDisplay
     dlopen ("libcairo.so.2", RTLD_LAZY);
 
-    memset (&switcherContext, 0, sizeof (WallCairoContext));
-    memset (&thumbContext, 0, sizeof (WallCairoContext));
-    memset (&highlightContext, 0, sizeof (WallCairoContext));
-    memset (&arrowContext, 0, sizeof (WallCairoContext));
     createCairoContexts (true);
 
 #define setAction(action, dir, win) \

=== modified file 'plugins/wall/src/wall.h'
--- plugins/wall/src/wall.h	2013-08-28 12:14:25 +0000
+++ plugins/wall/src/wall.h	2018-07-23 14:14:34 +0000
@@ -45,8 +45,10 @@
 } ScreenTransformation;
 
 /* FIXME: put into own class? */
-typedef struct _WallCairoContext
+struct WallCairoContext
 {
+    WallCairoContext ();
+
     Pixmap          pixmap;
     GLTexture::List texture;
 
@@ -55,7 +57,7 @@
 
     int width;
     int height;
-} WallCairoContext;
+};
 
 /* classes */
 class WallScreen :