Merge lp:~muktupavels/compiz/cython into lp:compiz/0.9.13

Proposed by Alberts Muktupāvels
Status: Merged
Approved by: Marco Trevisan (Treviño)
Approved revision: 4144
Merged at revision: 4145
Proposed branch: lp:~muktupavels/compiz/cython
Merge into: lp:compiz/0.9.13
Diff against target: 84 lines (+14/-12)
3 files modified
compizconfig/compizconfig-python/CMakeLists.txt (+7/-7)
compizconfig/compizconfig-python/src/compizconfig.pyx (+6/-4)
debian/control (+1/-1)
To merge this branch: bzr merge lp:~muktupavels/compiz/cython
Reviewer Review Type Date Requested Status
Marco Trevisan (Treviño) Approve
Compiz Maintainers Pending
Review via email: mp+348593@code.launchpad.net

Commit message

compizconfig-python: replace pyrex with cython.

Description of the change

Replace pyrex with cython. The former does not work with python 3.

To post a comment you must log in.
Revision history for this message
Marco Trevisan (Treviño) (3v1n0) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'compizconfig/compizconfig-python/CMakeLists.txt'
2--- compizconfig/compizconfig-python/CMakeLists.txt 2014-11-25 19:25:20 +0000
3+++ compizconfig/compizconfig-python/CMakeLists.txt 2018-06-27 10:33:58 +0000
4@@ -28,17 +28,17 @@
5 set (PY_BUILD_DIR lib.linux-${PROC_ARCH}-${PY_VERSION})
6 set (PY_SCRIPTS_DIR scripts-${PY_VERSION})
7 set (PY_COMPIZCONFIG_SRC ${CMAKE_CURRENT_BINARY_DIR}/compizconfig.c)
8-set (PY_COMPIZCONFIG_PYREX ${CMAKE_CURRENT_SOURCE_DIR}/src/compizconfig.pyx)
9+set (PY_COMPIZCONFIG_CYTHON ${CMAKE_CURRENT_SOURCE_DIR}/src/compizconfig.pyx)
10
11-find_program(PYREXC_BIN pyrexc)
12-if(NOT PYREXC_BIN)
13- message(FATAL_ERROR "Can not build because pyrexc binary not found.")
14+find_program(CYTHON_BIN cython)
15+if(NOT CYTHON_BIN)
16+ message(FATAL_ERROR "Can not build because cython binary not found.")
17 endif()
18
19 add_custom_command (OUTPUT ${PY_COMPIZCONFIG_SRC}
20- COMMAND ${PYREXC_BIN} -o ${PY_COMPIZCONFIG_SRC} ${PY_COMPIZCONFIG_PYREX}
21+ COMMAND ${CYTHON_BIN} -o ${PY_COMPIZCONFIG_SRC} ${PY_COMPIZCONFIG_CYTHON}
22 WORKING_DIRECTORY ${CMAKE_CURRENT_SOURCE_DIR}
23- DEPENDS ${PY_COMPIZCONFIG_PYREX})
24+ DEPENDS ${PY_COMPIZCONFIG_CYTHON})
25
26 file (READ ${CMAKE_SOURCE_DIR}/VERSION COMPIZ_RELEASE_VERSION LIMIT 12 OFFSET 0)
27 string (STRIP ${COMPIZ_RELEASE_VERSION} COMPIZ_RELEASE_VERSION)
28@@ -50,7 +50,7 @@
29 include_directories (${PYTHON_INCLUDE_DIRS}
30 ${COMPIZCONFIG_INCLUDE_DIRS})
31
32-# pyrex generates code that does type-punning, this trips
33+# cython generates code that does type-punning, this trips
34 # up -Werror
35 set (CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -Wno-strict-aliasing")
36
37
38=== modified file 'compizconfig/compizconfig-python/src/compizconfig.pyx'
39--- compizconfig/compizconfig-python/src/compizconfig.pyx 2012-09-05 08:05:54 +0000
40+++ compizconfig/compizconfig-python/src/compizconfig.pyx 2018-06-27 10:33:58 +0000
41@@ -164,8 +164,8 @@
42 Bool extensible
43
44 cdef struct CCSSettingListInfo:
45- CCSSettingType listType
46- void * listInfo # actually CCSSettingInfo *, works around pyrex
47+ CCSSettingType listType
48+ CCSSettingInfo * listInfo
49
50 cdef struct CCSSettingActionInfo:
51 Bool internal
52@@ -974,7 +974,8 @@
53
54 property EnableConflicts:
55 def __get__ (self):
56- cdef CCSPluginConflictList * pl, * pls
57+ cdef CCSPluginConflictList * pl
58+ cdef CCSPluginConflictList * pls
59 cdef CCSPluginConflict * pc
60 cdef CCSPluginList * ppl
61 cdef CCSPlugin * plg
62@@ -1002,7 +1003,8 @@
63
64 property DisableConflicts:
65 def __get__ (self):
66- cdef CCSPluginConflictList * pl, * pls
67+ cdef CCSPluginConflictList * pl
68+ cdef CCSPluginConflictList * pls
69 cdef CCSPluginConflict * pc
70 cdef CCSPluginList * ppl
71 cdef CCSPlugin * plg
72
73=== modified file 'debian/control'
74--- debian/control 2017-04-11 14:01:44 +0000
75+++ debian/control 2018-06-27 10:33:58 +0000
76@@ -52,7 +52,7 @@
77 libprotobuf-dev,
78 protobuf-compiler,
79 python-all-dev,
80- python-pyrex,
81+ cython,
82 gsettings-desktop-schemas-dev,
83 xserver-xorg-dev (>= 0.7.0),
84 Standards-Version: 3.9.8

Subscribers

People subscribed via source and target branches