Merge lp:~muktupavels/compiz/cmp0005 into lp:compiz/0.9.13

Proposed by Alberts Muktupāvels
Status: Merged
Approved by: Dmitry Shachnev
Approved revision: 4176
Merged at revision: 4176
Proposed branch: lp:~muktupavels/compiz/cmp0005
Merge into: lp:compiz/0.9.13
Prerequisite: lp:~muktupavels/compiz/cmp0003
Diff against target: 192 lines (+28/-33)
11 files modified
cmake/CompizCommon.cmake (+0/-1)
cmake/plugin_extensions/CompizGenInstallData.cmake (+1/-1)
compizconfig/libcompizconfig/src/CMakeLists.txt (+6/-6)
compizconfig/libcompizconfig/tests/CMakeLists.txt (+1/-1)
gtk/window-decorator/CMakeLists.txt (+3/-2)
plugins/dbus/CMakeLists.txt (+2/-2)
src/CMakeLists.txt (+3/-3)
src/plugin/CMakeLists.txt (+3/-3)
src/plugin/tests/CMakeLists.txt (+3/-5)
src/privatescreen/tests/CMakeLists.txt (+3/-5)
src/region/tests/CMakeLists.txt (+3/-4)
To merge this branch: bzr merge lp:~muktupavels/compiz/cmp0005
Reviewer Review Type Date Requested Status
Dmitry Shachnev Approve
Review via email: mp+350715@code.launchpad.net

Commit message

Don't set CMP0005 policy to OLD.

To post a comment you must log in.
Revision history for this message
Dmitry Shachnev (mitya57) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'cmake/CompizCommon.cmake'
2--- cmake/CompizCommon.cmake 2018-07-24 09:39:24 +0000
3+++ cmake/CompizCommon.cmake 2018-07-24 09:39:24 +0000
4@@ -13,7 +13,6 @@
5 #### policies
6
7 cmake_policy (SET CMP0002 OLD)
8-cmake_policy (SET CMP0005 OLD)
9 cmake_policy (SET CMP0011 OLD)
10 cmake_policy (SET CMP0022 OLD)
11
12
13=== modified file 'cmake/plugin_extensions/CompizGenInstallData.cmake'
14--- cmake/plugin_extensions/CompizGenInstallData.cmake 2013-02-20 13:55:12 +0000
15+++ cmake/plugin_extensions/CompizGenInstallData.cmake 2018-07-24 09:39:24 +0000
16@@ -23,5 +23,5 @@
17 DESTINATION ${PLUGIN_DATADIR}
18 )
19 endif (_install_plugin_${COMPIZ_CURRENT_PLUGIN})
20- list (APPEND COMPIZ_DEFINITIONS_ADD "-DDATADIR='\"${PLUGIN_DATADIR}\"'")
21+ list (APPEND COMPIZ_DEFINITIONS_ADD -DDATADIR="${PLUGIN_DATADIR}")
22 endif ()
23
24=== modified file 'compizconfig/libcompizconfig/src/CMakeLists.txt'
25--- compizconfig/libcompizconfig/src/CMakeLists.txt 2013-02-21 05:21:26 +0000
26+++ compizconfig/libcompizconfig/src/CMakeLists.txt 2018-07-24 09:39:24 +0000
27@@ -24,12 +24,12 @@
28
29 add_definitions (
30 -DHAVE_CONFIG_H
31- -DPLUGINDIR=\\\"${COMPIZ_PLUGINDIR}\\\"
32- -DIMAGEDIR=\\\"${COMPIZ_IMAGEDIR}\\\"
33- -DMETADATADIR=\\\"${COMPIZ_METADATADIR}\\\"
34- -DSYSCONFDIR=\\\"${COMPIZ_SYSCONFDIR}\\\"
35- -DDATADIR=\\\"${COMPIZ_DATADIR}\\\"
36- -DLIBDIR=\\\"${COMPIZ_LIBDIR}\\\"
37+ -DPLUGINDIR="${COMPIZ_PLUGINDIR}"
38+ -DIMAGEDIR="${COMPIZ_IMAGEDIR}"
39+ -DMETADATADIR="${COMPIZ_METADATADIR}"
40+ -DSYSCONFDIR="${COMPIZ_SYSCONFDIR}"
41+ -DDATADIR="${COMPIZ_DATADIR}"
42+ -DLIBDIR="${COMPIZ_LIBDIR}"
43 )
44
45 if (HAVE_PROTOBUF)
46
47=== modified file 'compizconfig/libcompizconfig/tests/CMakeLists.txt'
48--- compizconfig/libcompizconfig/tests/CMakeLists.txt 2015-07-30 19:56:19 +0000
49+++ compizconfig/libcompizconfig/tests/CMakeLists.txt 2018-07-24 09:39:24 +0000
50@@ -11,7 +11,7 @@
51
52 set (CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -std=c++11")
53
54-add_definitions (-DSYSCONFDIR=\\\"${COMPIZ_SYSCONFDIR}\\\")
55+add_definitions (-DSYSCONFDIR="${COMPIZ_SYSCONFDIR}")
56
57 add_executable (compizconfig_test_ccs_object
58 ${CMAKE_CURRENT_SOURCE_DIR}/compizconfig_test_ccs_object.cpp)
59
60=== modified file 'gtk/window-decorator/CMakeLists.txt'
61--- gtk/window-decorator/CMakeLists.txt 2016-06-08 10:34:32 +0000
62+++ gtk/window-decorator/CMakeLists.txt 2018-07-24 09:39:24 +0000
63@@ -13,10 +13,11 @@
64 ${DBUS_GLIB_INCLUDE_DIRS}
65 )
66
67+ string(REPLACE ";" " " LINGUAS "${ALL_LINGUAS}")
68 add_definitions (
69 -DHAVE_CONFIG_H
70- -DALL_LINGUAS=\"${ALL_LINGUAS}\"
71- -DLOCALEDIR=\\\"${datadir}/locale\\\"
72+ -DALL_LINGUAS=${LINGUAS}
73+ -DLOCALEDIR="${datadir}/locale"
74 )
75
76 link_directories (
77
78=== modified file 'plugins/dbus/CMakeLists.txt'
79--- plugins/dbus/CMakeLists.txt 2010-04-23 17:16:17 +0000
80+++ plugins/dbus/CMakeLists.txt 2018-07-24 09:39:24 +0000
81@@ -4,8 +4,8 @@
82
83 add_definitions (
84 -DHAVE_CONFIG_H
85- -DPLUGINDIR=\\\"${compiz_plugindir}\\\"
86- -DMETADATADIR=\\\"${compiz_metadatadir}\\\"
87+ -DPLUGINDIR="${compiz_plugindir}"
88+ -DMETADATADIR="${compiz_metadatadir}"
89 )
90
91 compiz_plugin (dbus PKGDEPS dbus-1 libxml-2.0)
92
93=== modified file 'src/CMakeLists.txt'
94--- src/CMakeLists.txt 2013-01-03 16:05:26 +0000
95+++ src/CMakeLists.txt 2018-07-24 09:39:24 +0000
96@@ -82,9 +82,9 @@
97
98 add_definitions (
99 -DHAVE_CONFIG_H
100- -DPLUGINDIR=\\\"${compiz_plugindir}\\\"
101- -DSHAREDIR=\\\"${compiz_sharedir}\\\"
102- -DMETADATADIR=\\\"${compiz_metadatadir}\\\"
103+ -DPLUGINDIR="${compiz_plugindir}"
104+ -DSHAREDIR="${compiz_sharedir}"
105+ -DMETADATADIR="${compiz_metadatadir}"
106 )
107
108 get_property (CORE_MOD_LIBRARY_DIRS
109
110=== modified file 'src/plugin/CMakeLists.txt'
111--- src/plugin/CMakeLists.txt 2012-09-29 15:35:59 +0000
112+++ src/plugin/CMakeLists.txt 2018-07-24 09:39:24 +0000
113@@ -26,9 +26,9 @@
114
115 add_definitions (
116 -DHAVE_CONFIG_H
117- -DPLUGINDIR=\\\"${compiz_plugindir}\\\"
118- -DSHAREDIR=\\\"${compiz_sharedir}\\\"
119- -DMETADATADIR=\\\"${compiz_metadatadir}\\\"
120+ -DPLUGINDIR="${compiz_plugindir}"
121+ -DSHAREDIR="${compiz_sharedir}"
122+ -DMETADATADIR="${compiz_metadatadir}"
123 )
124
125 SET( SRCS ${compiz_SOURCE_DIR}/src/plugin.cpp )
126
127=== modified file 'src/plugin/tests/CMakeLists.txt'
128--- src/plugin/tests/CMakeLists.txt 2013-04-22 14:30:55 +0000
129+++ src/plugin/tests/CMakeLists.txt 2018-07-24 09:39:24 +0000
130@@ -10,12 +10,11 @@
131
132 add_definitions (
133 -DHAVE_CONFIG_H
134- -DPLUGINDIR=\\\"${compiz_plugindir}\\\"
135- -DSHAREDIR=\\\"${compiz_sharedir}\\\"
136- -DMETADATADIR=\\\"${compiz_metadatadir}\\\"
137+ -DPLUGINDIR="${compiz_plugindir}"
138+ -DSHAREDIR="${compiz_sharedir}"
139+ -DMETADATADIR="${compiz_metadatadir}"
140 )
141
142-
143 add_executable(
144 compiz_plugin_test
145
146@@ -33,4 +32,3 @@
147 )
148
149 compiz_discover_tests ( compiz_plugin_test COVERAGE compiz_plugin compiz_core )
150-
151
152=== modified file 'src/privatescreen/tests/CMakeLists.txt'
153--- src/privatescreen/tests/CMakeLists.txt 2013-04-22 14:30:55 +0000
154+++ src/privatescreen/tests/CMakeLists.txt 2018-07-24 09:39:24 +0000
155@@ -26,15 +26,13 @@
156 ${Boost_INCLUDE_DIRS}
157 )
158
159-
160 add_definitions (
161 -DHAVE_CONFIG_H
162- -DPLUGINDIR=\\\"${compiz_plugindir}\\\"
163- -DSHAREDIR=\\\"${compiz_sharedir}\\\"
164- -DMETADATADIR=\\\"${compiz_metadatadir}\\\"
165+ -DPLUGINDIR="${compiz_plugindir}"
166+ -DSHAREDIR="${compiz_sharedir}"
167+ -DMETADATADIR="${compiz_metadatadir}"
168 )
169
170-
171 add_executable(
172 compiz_privatescreen_test
173
174
175=== modified file 'src/region/tests/CMakeLists.txt'
176--- src/region/tests/CMakeLists.txt 2013-04-22 14:30:55 +0000
177+++ src/region/tests/CMakeLists.txt 2018-07-24 09:39:24 +0000
178@@ -9,12 +9,11 @@
179
180 add_definitions (
181 -DHAVE_CONFIG_H
182- -DPLUGINDIR=\\\"${compiz_plugindir}\\\"
183- -DSHAREDIR=\\\"${compiz_sharedir}\\\"
184- -DMETADATADIR=\\\"${compiz_metadatadir}\\\"
185+ -DPLUGINDIR="${compiz_plugindir}"
186+ -DSHAREDIR="${compiz_sharedir}"
187+ -DMETADATADIR="${compiz_metadatadir}"
188 )
189
190-
191 add_executable(
192 compiz_region_test
193

Subscribers

People subscribed via source and target branches