Merge lp:~muffinresearch/phazr/click-outside-to-dismiss into lp:phazr

Proposed by Stuart Colville
Status: Merged
Approved by: Paul Hummer
Approved revision: 32
Merged at revision: 11
Proposed branch: lp:~muffinresearch/phazr/click-outside-to-dismiss
Merge into: lp:phazr
Prerequisite: lp:~rockstar/phazr/combo-loader-friendly
Diff against target: 26 lines (+11/-1)
1 file modified
src/js/phazroverlay/phazroverlay.js (+11/-1)
To merge this branch: bzr merge lp:~muffinresearch/phazr/click-outside-to-dismiss
Reviewer Review Type Date Requested Status
Paul Hummer Approve
Review via email: mp+63728@code.launchpad.net

This proposal supersedes a proposal from 2011-06-07.

Commit message

Allow clicking outside the dialog to close it

Description of the change

Add click outside to dismiss modal dialogue.

To post a comment you must log in.
Revision history for this message
Paul Hummer (rockstar) :
review: Approve
Revision history for this message
Paul Hummer (rockstar) wrote :

The prerequisite lp:~rockstar/phazr/combo-loader-friendly has not yet been merged into lp:phazr.

Revision history for this message
Paul Hummer (rockstar) wrote :

The prerequisite lp:~rockstar/phazr/combo-loader-friendly has not yet been merged into lp:phazr.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/js/phazroverlay/phazroverlay.js'
2--- src/js/phazroverlay/phazroverlay.js 2011-06-07 16:05:01 +0000
3+++ src/js/phazroverlay/phazroverlay.js 2011-06-07 16:05:01 +0000
4@@ -38,6 +38,16 @@
5 handle: header
6 });
7 this.set('dragDelegate', dd);
8+
9+ Y.one("html").on("modaloutside|click",
10+ function(e) {
11+ var targ = e.target;
12+ if (!box.contains(targ)) {
13+ this.hide();
14+ Y.detach("modaloutside|click");
15+ }
16+ },
17+ this);
18 }
19 };
20
21@@ -50,4 +60,4 @@
22 'overlay',
23 'plugin',
24 'substitute'
25-]})
26+]});

Subscribers

People subscribed via source and target branches