mudlet:development

Last commit made on 2024-04-22
Get this branch:
git clone -b development https://git.launchpad.net/mudlet

Branch merges

Branch information

Name:
development
Repository:
lp:mudlet

Recent commits

98b7eff... by Vadim Peretokin <email address hidden>

Add: automatically update map on all changes via API (#7187)

<!-- Keep the title short & concise so anyone non-technical can
understand it,
     the title appears in PTB changelogs -->
#### Brief overview of PR changes/additions
Automatically update map on all map changes via API while not losing
performance.
#### Motivation for adding to Mudlet
Better user experience.
#### Other info (issues closed, discussion etc)
Alleviates the need for calling
https://wiki.mudlet.org/w/Manual:Mapper_Functions#updateMap and fixes
the inconsistency where some functions were updating the map
automatically and others haven't.

---------

Co-authored-by: Vadim Peretokin <email address hidden>
Co-authored-by: Kebap <email address hidden>

9b362cf... by Tim Johnson <email address hidden>

Infra: update mirror URL for file hosted by osdn (#7200)

<!-- Keep the title short & concise so anyone non-technical can
understand it,
     the title appears in PTB changelogs -->
#### Brief overview of PR changes/additions
Change the URL of file mentioned at
https://osdn.net/projects/mingw/downloads/68260/mingw-get-0.6.3-mingw32-pre-20170905-1-bin.zip/

#### Motivation for adding to Mudlet
Builds were failing, but not every time, like
https://ci.appveyor.com/project/Mudlet/mudlet/builds/49542655
Last lines were
```
==== compiling and installing mingw-get ====
---- Downloading ----
Exception calling "DownloadFile" with "2" argument(s): "The underlying connection was closed: Could not establish
trust relationship for the SSL/TLS secure channel."
```
I looked in the script files and found URL associated with mingw-get and
downloaded it myself a few times. It uses a 302 Location redirect going
to 2 different URLs, sometimes working and others with an expired
certificate.
Then I found the link above which is similar URL but different `m=`.
Looks like `m` is for mirror, and the old one is name of a German
university that maybe is no longer mirroring for them or something.

#### Other info (issues closed, discussion etc)
Discussion started with
https://discord.com/channels/283581582550237184/283582439002210305/1225440152621551698

0ac53a3... by Vadim Peretokin <email address hidden>

Add: GMCP authenticate spec implementation (#7152)

<!-- Keep the title short & concise so anyone non-technical can
understand it,
     the title appears in PTB changelogs -->
#### Brief overview of PR changes/additions
Add the GMCP authenticate spec and client credentials:
https://wiki.mudlet.org/w/Standards:GMCP_Authentication
#### Motivation for adding to Mudlet
To solve the issues we have in trying to login to games - not every game
accepts "character\npassword" kind of login - while not getting into a
security quagmire that comes with exposing passwords to the Lua
subsystem.
#### Other info (issues closed, discussion etc)

---------

Co-authored-by: Vadim Peretokin <email address hidden>
Co-authored-by: Marco Fontani <email address hidden>
Co-authored-by: Stephen Lyons <email address hidden>

598ec5a... by "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com>

Infrastructure: Bump ZedThree/clang-tidy-review from 0.17.2 to 0.18.0 (#7196)

Bumps
[ZedThree/clang-tidy-review](https://github.com/zedthree/clang-tidy-review)
from 0.17.2 to 0.18.0.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a
href="https://github.com/zedthree/clang-tidy-review/releases">ZedThree/clang-tidy-review's
releases</a>.</em></p>
<blockquote>
<h2>v0.18.0</h2>
<h2>What's Changed</h2>
<ul>
<li>chore: add <code>num_comments_as_exitcode</code> option by <a
href="https://github.com/Nerixyz"><code>@​Nerixyz</code></a> in <a
href="https://redirect.github.com/ZedThree/clang-tidy-review/pull/119">ZedThree/clang-tidy-review#119</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a
href="https://github.com/ZedThree/clang-tidy-review/compare/v0.17.3...v0.18.0">https://github.com/ZedThree/clang-tidy-review/compare/v0.17.3...v0.18.0</a></p>
<h2>v0.17.3</h2>
<h2>What's Changed</h2>
<ul>
<li>fix: download artifacts as binary blobs and follow redirects by <a
href="https://github.com/Nerixyz"><code>@​Nerixyz</code></a> in <a
href="https://redirect.github.com/ZedThree/clang-tidy-review/pull/118">ZedThree/clang-tidy-review#118</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a
href="https://github.com/ZedThree/clang-tidy-review/compare/v0.17.2...v0.17.3">https://github.com/ZedThree/clang-tidy-review/compare/v0.17.2...v0.17.3</a></p>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a
href="https://github.com/ZedThree/clang-tidy-review/commit/900895863e31d749b3a97e8d4de93f15927d235f"><code>9008958</code></a>
Merge pull request <a
href="https://redirect.github.com/zedthree/clang-tidy-review/issues/119">#119</a>
from Nerixyz/chore/exit-with-comments</li>
<li><a
href="https://github.com/ZedThree/clang-tidy-review/commit/ad2c4db7abdabbc45acae2eea61a0e5d35a0a753"><code>ad2c4db</code></a>
chore: add <code>num_comments_as_exitcode</code> option</li>
<li><a
href="https://github.com/ZedThree/clang-tidy-review/commit/fddb61679ee7c22752af2436323967203d44d4a1"><code>fddb616</code></a>
Merge pull request <a
href="https://redirect.github.com/zedthree/clang-tidy-review/issues/118">#118</a>
from Nerixyz/fix/more-pr</li>
<li><a
href="https://github.com/ZedThree/clang-tidy-review/commit/1d30432c20c44eaecaa73a751591416d4dc9fe4b"><code>1d30432</code></a>
fix: download artifact as blob and follow redirects</li>
<li><a
href="https://github.com/ZedThree/clang-tidy-review/commit/3fb42e9e885549bfa69acb9b53775dd0cd09ab32"><code>3fb42e9</code></a>
deps: update to <code>actions/upload-action@v4</code></li>
<li>See full diff in <a
href="https://github.com/zedthree/clang-tidy-review/compare/v0.17.2...v0.18.0">compare
view</a></li>
</ul>
</details>
<br />

[![Dependabot compatibility
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=ZedThree/clang-tidy-review&package-manager=github_actions&previous-version=0.17.2&new-version=0.18.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't
alter it yourself. You can also trigger a rebase manually by commenting
`@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits
that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after
your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge
and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating
it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all
of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop
Dependabot creating any more for this major version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop
Dependabot creating any more for this minor version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop
Dependabot creating any more for this dependency (unless you reopen the
PR or upgrade to it yourself)

</details>

Signed-off-by: dependabot[bot] <email address hidden>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

1d50752... by Zooka <email address hidden>

Fix map.renameArea function calls. (#7174)

Calling setAreaName() before the echo resulted in the wrong area name
being sent to the user. Call setAreaName() after instead.

<!-- Keep the title short & concise so anyone non-technical can
understand it,
     the title appears in PTB changelogs -->
#### Brief overview of PR changes/additions
Using 'area rename' command would show
`> area rename New Area Name`
`(mapper): Renamed New Area Name to New Area Name (5).`

now displays correctly
`(mapper): Renamed Old Area Name to New Area Name (5).`

#### Motivation for adding to Mudlet
Improve user experience.

#### Other info (issues closed, discussion etc)
Fix will apply to IRE mapping script as well.

97ac27c... by "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com>

Infrastructure: Bump ZedThree/clang-tidy-review from 0.17.1 to 0.17.2 (#7192)

Bumps
[ZedThree/clang-tidy-review](https://github.com/zedthree/clang-tidy-review)
from 0.17.1 to 0.17.2.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a
href="https://github.com/zedthree/clang-tidy-review/releases">ZedThree/clang-tidy-review's
releases</a>.</em></p>
<blockquote>
<h2>v0.17.2</h2>
<h2>What's Changed</h2>
<ul>
<li>fix: artifact download by <a
href="https://github.com/Nerixyz"><code>@​Nerixyz</code></a> in <a
href="https://redirect.github.com/ZedThree/clang-tidy-review/pull/115">ZedThree/clang-tidy-review#115</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a
href="https://github.com/ZedThree/clang-tidy-review/compare/v0.17.1...v0.17.2">https://github.com/ZedThree/clang-tidy-review/compare/v0.17.1...v0.17.2</a></p>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a
href="https://github.com/ZedThree/clang-tidy-review/commit/9a32adc734e10e4d84baa60f2b7d7c021568c527"><code>9a32adc</code></a>
Merge pull request <a
href="https://redirect.github.com/zedthree/clang-tidy-review/issues/115">#115</a>
from Nerixyz/fix/pr-stuff</li>
<li><a
href="https://github.com/ZedThree/clang-tidy-review/commit/0b130f269717236c93c2dcbd01c8c80d9136c3e5"><code>0b130f2</code></a>
fix: artifact download</li>
<li>See full diff in <a
href="https://github.com/zedthree/clang-tidy-review/compare/v0.17.1...v0.17.2">compare
view</a></li>
</ul>
</details>
<br />

[![Dependabot compatibility
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=ZedThree/clang-tidy-review&package-manager=github_actions&previous-version=0.17.1&new-version=0.17.2)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't
alter it yourself. You can also trigger a rebase manually by commenting
`@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits
that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after
your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge
and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating
it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all
of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop
Dependabot creating any more for this major version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop
Dependabot creating any more for this minor version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop
Dependabot creating any more for this dependency (unless you reopen the
PR or upgrade to it yourself)

</details>

Signed-off-by: dependabot[bot] <email address hidden>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

a6dc321... by Stephen Lyons

Fix: typo in previous commit omitted a space (#7182)

#### Brief overview of PR changes/additions
Adds a space that is not functionally required (apparently) but which is
required for human readability.

#### Motivation for adding to Mudlet
Clean a mistake I made last time

#### Other info (issues closed, discussion etc)
Caused by my #7179.

Signed-off-by: Stephen Lyons <email address hidden>

28eb986... by Stephen Lyons

Infrastructure: remove some unused variables left behind after a recent PR (#7180)

#### Brief overview of PR changes/additions
Remove some unused local variables left over from a recent PR.

#### Motivation for adding to Mudlet
These generate warnings from some code analysers (e.g. clang-tidy) that
might swamp more important warnings that we do need to worry about. Some
of the variable declarations do not even include an initialisation which
is something that analysers also get unhappy about.

#### Other info (issues closed, discussion etc)
It looks like this came about in #7167.

Signed-off-by: Stephen Lyons <email address hidden>

344d7a4... by Stephen Lyons

Infrastructure: reposition const before type specifier (#7179)

#### Brief overview of PR changes/additions
This PR tries to put all `const`s before the type (class).

#### Motivation for adding to Mudlet
There is a mix of positioning of `const`s where it is used to indicate
that a variable is not to be modified by program code, we tend to put it
before the type but a prior PR (which looks to have been done with an
automated tool) has resulted in a mix of cases some with the const
adjacent to the variable. This lack of consistency can be confusing.

#### Other info (issues closed, discussion etc)
It looks like this came about in #6843.

This will upset the Danger detector because of the number of files
modified but it should be fairly straightforward to review.

Signed-off-by: Stephen Lyons <email address hidden>

7536070... by Stephen Lyons

Improve: add controlCharacterHandling to Lua get- & set-config (#7176)

#### Brief overview of PR changes/additions
Extend `TLuaInterpreter::setConfig(...)` and
`TLuaInterpreter::getConfig(...)` for an additional case:
`controlCharacterHandling` and also add that "key" to the list in the
external `./mudlet-lua/lua/Other.lua` script file so the no argument
`getConfig()` case includes it as well.

#### Motivation for adding to Mudlet
Medievia MUD will want this to enable a package to configure this to
`"oem"` (out of the other `"asis"` and `"picture"` options).

#### Other info (issues closed, discussion etc)
Also rename a couple of variables in the section of `"caretShortcut"`
for the `setConfig(...)` case as it was using `key`/`keys` for things
that are `value`/`values`!

Also improve a couple of other setConfig cases (`caretShortcut` and
`commandLineHistorySaveSize`) which take one of a number of values so
that entering an invalid string produces a `nil` + error message rather
than throwing an error - as is our practice for other run-time value
(rather than type) problems.

Signed-off-by: Stephen Lyons <email address hidden>