Merge lp:~mttronchetti/novacut/help into lp:novacut

Proposed by Matteo Ronchetti
Status: Merged
Merged at revision: 284
Proposed branch: lp:~mttronchetti/novacut/help
Merge into: lp:novacut
Diff against target: 138 lines (+72/-2) (has conflicts)
5 files modified
ui/bucket.css (+19/-0)
ui/bucket.html (+35/-1)
ui/bucket.js (+16/-0)
ui/projects.html (+1/-1)
ui/projects.js (+1/-0)
Text conflict in ui/bucket.html
To merge this branch: bzr merge lp:~mttronchetti/novacut/help
Reviewer Review Type Date Requested Status
Jason Gerard DeRose Approve
Review via email: mp+115692@code.launchpad.net

Description of the change

Added the commands/shortcuts window and fixed a small bug

To post a comment you must log in.
lp:~mttronchetti/novacut/help updated
283. By Matteo Ronchetti

added a new shortcut in the window

Revision history for this message
Jason Gerard DeRose (jderose) wrote :

Overall it looks good, but there's one change I'd like: can you remove the novacut.com link and replace it with this help instead (same place in the grid). Also, can you change the text from help to Keyboard Shortcuts?

review: Needs Fixing
lp:~mttronchetti/novacut/help updated
284. By Matteo Ronchetti

changed name in keyboard shortcuts

Revision history for this message
Jason Gerard DeRose (jderose) wrote :

Looks great, thanks!

One note: I'd like to hold off on adding any more keyboard shortcuts till we've done detailed design work on this, really have a plan.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'ui/bucket.css'
2--- ui/bucket.css 2012-04-29 22:12:50 +0000
3+++ ui/bucket.css 2012-07-23 07:59:18 +0000
4@@ -539,3 +539,22 @@
5 margin: 0;
6 pointer-events: none;
7 }
8+
9+#shortcuts{
10+ position:fixed;
11+ background-color: rgba(15, 15, 15, 0.85);
12+text-shadow: 2px 2px 3px rgba(255, 0, 0, 0.5);
13+ box-shadow: 0px 0px 10px 0px #e81f3b;
14+ border-radius: 12px;
15+ font-size: 16px;
16+ display:none;
17+ z-index:999;
18+}
19+#shortcuts table{
20+ padding: 20px;
21+}
22+#shortcuts td{
23+ padding-top :4px;
24+ padding-left: 15px;
25+ padding-right: 15px;
26+}
27
28=== modified file 'ui/bucket.html'
29--- ui/bucket.html 2012-07-23 01:54:11 +0000
30+++ ui/bucket.html 2012-07-23 07:59:18 +0000
31@@ -45,14 +45,48 @@
32 <div class="fgrid_row"><strong class="fgrid_2">.</strong></div>
33
34 <div class="fgrid_row">
35+<<<<<<< TREE
36 <strong class="fgrid_4 version">Novacut 12.08.0</strong>
37 <a href="http://novacut.com" class="fgrid_3">novacut.com</a>
38+=======
39+ <strong class="fgrid_4 version">Novacut 12.07.0</strong>
40+<a onclick="showShort(event);" style="cursor: pointer; margin-right:135px;">Keyboard Shortcuts</a>
41+>>>>>>> MERGE-SOURCE
42 <a href="http://www.kickstarter.com/projects/novacut/novacut-pro-video-editor/backers" class="fgrid_5">Thanks to our Kickstarter backers!</a>
43 </div>
44 </div>
45 </div>
46
47-<div id="bucket"></div>
48+<div id="bucket">
49+<div id="shortcuts" >
50+<table border="0">
51+ <tr>
52+ <td>D</td>
53+ <td>Duplicate slice</td>
54+ </tr>
55+ <tr>
56+ <td>Del</td>
57+ <td>Delete slice</td>
58+ </tr>
59+ <tr>
60+ <td>Space bar</td>
61+ <td>Play/Pause</td>
62+ </tr>
63+ <tr>
64+ <td>Esc</td>
65+ <td>Close</td>
66+ </tr>
67+ <tr>
68+ <td>Mouse wheel</td>
69+ <td>Move of one frame</td>
70+ </tr>
71+ <tr>
72+ <td>Shift+Mouse Wheel</td>
73+ <td>Move of ten frames</td>
74+ </tr>
75+</table>
76+</div>
77+</div>
78 <div id="sequence" clas="lower"></div>
79 <div id="roughcut" class="hide">
80 <div class="grid_row">
81
82=== modified file 'ui/bucket.js'
83--- ui/bucket.js 2012-06-15 10:20:06 +0000
84+++ ui/bucket.js 2012-07-23 07:59:18 +0000
85@@ -1661,6 +1661,8 @@
86 window.addEventListener('keyup', UI.on_keyup);
87 UI.bucket = $('bucket');
88 UI.orb = new LoveOrb();
89+ document.getElementById('shortcuts').style.marginTop = window.innerHeight/2-200+"px";
90+ document.getElementById('shortcuts').style.marginLeft = window.innerWidth/2-255+"px";
91
92 // Create and start the CouchDB session
93 UI.session = new couch.Session(UI.db, UI.on_new_doc);
94@@ -1947,6 +1949,20 @@
95 },
96 }
97
98+function showShort(event){
99+ console.log('show');
100+ UI.orb.toggle();
101+ document.getElementById("shortcuts").style.display = "block";
102+ event.stopPropagation();
103+ document.body.onclick = $bind(hideShort);
104+}
105+
106+function hideShort(event){
107+ console.log('hide');
108+ document.getElementById("shortcuts").style.display = "none";
109+ event.stopPropagation();
110+}
111+
112 window.addEventListener('load', UI.init);
113
114
115
116=== modified file 'ui/projects.html'
117--- ui/projects.html 2012-07-16 16:40:20 +0000
118+++ ui/projects.html 2012-07-23 07:59:18 +0000
119@@ -172,6 +172,6 @@
120 </li></ul>
121 </div>
122 </form>
123-<ul style="height: 800px;width = 800px;" id="projects" ondragenter="enter(event)" ondragleave="leave(event)" ondrop="d(event)" ondragover="over(event);"></ul>
124+<ul style="min-width = 800px;" id="projects" ondragenter="enter(event)" ondragleave="leave(event)" ondrop="d(event)" ondragover="over(event);"></ul>
125 </body>
126 </html>
127
128=== modified file 'ui/projects.js'
129--- ui/projects.js 2012-07-16 13:17:30 +0000
130+++ ui/projects.js 2012-07-23 07:59:18 +0000
131@@ -45,6 +45,7 @@
132
133 UI.hist = document.getElementById('list');
134 UI.proj = document.getElementById('projects');
135+ UI.proj.style.height = window.innerHeight-50+"px";
136
137
138 UI.binDesc ="<p>Here you can find your removed projects<br>Click on <img style=\"width:13px;\" src=\"delete.png\"></img>&nbsp;&nbsp;&nbsp;to remove a project<br>Drag a project out of here to restore it</p>";

Subscribers

People subscribed via source and target branches

to all changes:
to status/vote changes: