Merge lp:~mttronchetti/novacut/bin into lp:novacut
Status: | Merged | ||||
---|---|---|---|---|---|
Merged at revision: | 281 | ||||
Proposed branch: | lp:~mttronchetti/novacut/bin | ||||
Merge into: | lp:novacut | ||||
Diff against target: |
336 lines (+162/-50) 2 files modified
ui/projects.html (+93/-33) ui/projects.js (+69/-17) |
||||
To merge this branch: | bzr merge lp:~mttronchetti/novacut/bin | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Jason Gerard DeRose | Approve | ||
Review via email:
|
Description of the change
I did some improvements related to the ex history menu:
1)Calling it history was a bad idea so I removed history name and I've replaced it with a bin icon.In my opinion is easy to understand what this icon stands for so it is good.The small problem is that I have drawn the icon so it is OK but nothing amazing but easy to understand
2)I have made the bin menu looking like this:
if there aren't removed projects display a simple description of the menu as suggested in this bug https:/
if there are less than 5 projects show them
if there are more than 5 projects show the first 5 and also a real time search bar(really cool)
3)To make more understandable where removed projects go I added an animation
4)The small cross that allows you to remove projects now shows you that it is clickable by changing its transparency on mouse over
5)The menu is already shown by onmouseover but I have improved usability using an invisible div that makes easier to move the mouse from the bin icon to the menu.In my opinion it is better than open the menu with a click
I' m very proud of my work but if you don't agree with something tell it to me so we can talk about this and improve novacut :P
P.S. I have done some usability tests with my sister and they went good
I love the new feature. You just need to fix the needless chmod changes, please, and then I'll merge this.
just chmod +x on the scripts you see in the diff, and then commit.