Merge lp:~mthaddon/juju-website/version-2-fix-https-favicon into lp:~canonical-website-editors/juju-website/version-2

Proposed by Tom Haddon
Status: Merged
Merged at revision: 28
Proposed branch: lp:~mthaddon/juju-website/version-2-fix-https-favicon
Merge into: lp:~canonical-website-editors/juju-website/version-2
Diff against target: 19 lines (+2/-2)
1 file modified
header.php (+2/-2)
To merge this branch: bzr merge lp:~mthaddon/juju-website/version-2-fix-https-favicon
Reviewer Review Type Date Requested Status
Anthony Dillon Approve
Review via email: mp+200410@code.launchpad.net

Description of the change

Per https://wiki.canonical.com/InformationInfrastructure/ISO/Websites/JujuDotUbuntuDotCom#Update_the_.22ubuntu.22_Theme this seems to be the actual branch we deploy from.

This fixes juju.ubuntu.com so that the favicon comes from https if the rest of the site is being served on https to avoid browser warnings. I've cowboyed this place in change on juju.ubuntu.com to confirm, so when you're ready to rollout, you'll want to note that in the deployment RT.

To post a comment you must log in.
Revision history for this message
Anthony Dillon (ya-bo-ng) wrote :

LGTM. Thank you very much.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'header.php'
2--- header.php 2013-12-03 17:46:28 +0000
3+++ header.php 2014-01-03 15:48:16 +0000
4@@ -46,7 +46,7 @@
5 <!-- Google Chrome Frame for IE -->
6 <meta http-equiv="X-UA-Compatible" content="IE=edge,chrome=1" />
7
8-<link rel="shortcut icon" href="http://assets.ubuntu.com/sites/ubuntu/latest/u/img/favicon.ico" />
9+<link rel="shortcut icon" href="//assets.ubuntu.com/sites/ubuntu/latest/u/img/favicon.ico" />
10 <link rel="pingback" href="<?php bloginfo('pingback_url'); ?>" />
11 <script src="/wp-content/themes/ubuntu/library/js/all-yui.js"></script>
12
13@@ -119,4 +119,4 @@
14 </ul>
15 </nav>
16 </div>
17-<?php } ?>
18\ No newline at end of file
19+<?php } ?>

Subscribers

People subscribed via source and target branches