Merge lp:~mthaddon/codetree/core20-snap into lp:codetree

Proposed by Tom Haddon
Status: Merged
Approved by: Tom Haddon
Approved revision: 128
Merged at revision: 123
Proposed branch: lp:~mthaddon/codetree/core20-snap
Merge into: lp:codetree
Diff against target: 36 lines (+11/-2)
1 file modified
snapcraft.yaml (+11/-2)
To merge this branch: bzr merge lp:~mthaddon/codetree/core20-snap
Reviewer Review Type Date Requested Status
Junien F Approve
Canonical IS Reviewers Pending
Review via email: mp+397493@code.launchpad.net

Commit message

Build snap on core20

To post a comment you must log in.
Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote :

This merge proposal is being monitored by mergebot. Change the status to Approved to merge.

lp:~mthaddon/codetree/core20-snap updated
128. By Tom Haddon

Use qualified path to ensure we're using the right python3 version

Revision history for this message
Junien F (axino) wrote :

+1

review: Approve
Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote :

Change successfully merged at revision 123

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'snapcraft.yaml'
2--- snapcraft.yaml 2020-05-05 06:42:15 +0000
3+++ snapcraft.yaml 2021-02-04 13:21:16 +0000
4@@ -3,12 +3,16 @@
5 description: A tool for collating and building trees of files from various sources.
6 # Switch to strict once https://bugs.launchpad.net/snappy/+bug/1657021
7 # is addressed.
8+base: core20
9 confinement: classic
10 adopt-info: codetree
11 grade: stable
12 apps:
13 codetree:
14- command: bin/codetree
15+ command: bin/python3 $SNAP/bin/codetree
16+ environment:
17+ PATH: $PATH:$SNAP/usr/bin
18+ PYTHONPATH: $SNAP/lib/python3.8/site-packages
19 # Classic mode has no plugs.
20 # plugs:
21 # - home
22@@ -17,8 +21,13 @@
23 parts:
24 codetree:
25 plugin: python
26- python-version: python3
27+ python-packages:
28+ - pip
29+ - setuptools
30+ - wheel
31 source: .
32+ build-packages:
33+ - bzr
34 stage-packages:
35 - bzr
36 - git

Subscribers

People subscribed via source and target branches