Merge ~mthaddon/charm-ubuntu-advantage/+git/charm-ubuntu-advantage:lpcraft into charm-ubuntu-advantage:master
Proposed by
Tom Haddon
| Status: | Merged |
|---|---|
| Approved by: | Haw Loeung |
| Approved revision: | db2da4d65977c0eff507f1c7615c3f8ab31a62c0 |
| Merged at revision: | 4c17fc761d4a5ab2dbda2c90bb1500e3096199a2 |
| Proposed branch: | ~mthaddon/charm-ubuntu-advantage/+git/charm-ubuntu-advantage:lpcraft |
| Merge into: | charm-ubuntu-advantage:master |
| Diff against target: |
25 lines (+19/-0) 1 file modified
.launchpad.yaml (+19/-0) |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Haw Loeung | +1 | Approve | |
| Canonical IS Reviewers | Pending | ||
|
Review via email:
|
|||
Commit message
Add lint and unit tests to each commit with lpcraft
Description of the change
Add lint and unit tests to each commit with lpcraft.
This can be run locally with `lpcraft run` (after installing the lpcraft snap), or will now be run on every commit, and output will be shown in merge proposals as below. Not including integration tests yet, as we'll need to work out if it's possible to spin up LXC within LXC to run those. That can come in a later commit.
To post a comment you must log in.
Revision history for this message
| 🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote | # |
Revision history for this message
| 🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote | # |
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
This merge proposal is being monitored by mergebot. Change the status to Approved to merge.