Merge ~mthaddon/charm-k8s-wordpress/+git/charm-k8s-wordpress:dockerfile-cleanup into charm-k8s-wordpress:master

Proposed by Tom Haddon
Status: Merged
Approved by: Tom Haddon
Approved revision: fdd68fa5a318d17feabaffba719347f05b401d5e
Merged at revision: f7316fa1c552d60a5865c3edad746c5920c65778
Proposed branch: ~mthaddon/charm-k8s-wordpress/+git/charm-k8s-wordpress:dockerfile-cleanup
Merge into: charm-k8s-wordpress:master
Diff against target: 22 lines (+2/-4)
1 file modified
Dockerfile (+2/-4)
Reviewer Review Type Date Requested Status
Laurent Sesquès Approve
Canonical IS Reviewers Pending
Review via email: mp+396038@code.launchpad.net

Commit message

Remove duplicated argument and label definition from Dockerfile

Description of the change

Remove duplicated argument and label definition from Dockerfile

To post a comment you must log in.
Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote :

This merge proposal is being monitored by mergebot. Change the status to Approved to merge.

Revision history for this message
Laurent Sesquès (sajoupa) :
review: Approve
Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote :

Change successfully merged at revision f7316fa1c552d60a5865c3edad746c5920c65778

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/Dockerfile b/Dockerfile
2index 7603e5c..50a5120 100644
3--- a/Dockerfile
4+++ b/Dockerfile
5@@ -4,15 +4,13 @@ ARG DIST_RELEASE
6 ARG VERSION
7
8 LABEL maintainer="wordpress-charmers@lists.launchpad.net"
9-LABEL org.label-schema.version=${DIST_RELEASE}-${VERSION}
10+# Used by Launchpad OCI Recipe to tag version
11+LABEL org.label-schema.version=${VERSION:-5.6}
12
13 # HTTPS_PROXY used when we RUN curl to download Wordpress itself
14 ARG BUILD_DATE
15 ARG HTTPS_PROXY
16-ARG VERSION
17
18-# Used by Launchpad OCI Recipe to tag version
19-LABEL org.label-schema.version=${VERSION:-5.6}
20
21 # Launchpad OCI image builds don't support dynamic arg parsing. Skip until
22 # https://bugs.launchpad.net/launchpad/+bug/1902010 is resolved.

Subscribers

People subscribed via source and target branches

to all changes: