Merge ~mthaddon/charm-k8s-unifi-poller/+git/charm-k8s-unifi-poller:test-bad-url-scheme into charm-k8s-unifi-poller:master

[Tom Haddon]

Add test of invalid netloc, as well as valid url to confirm we're exercising both code paths

Add test of invalid netloc, as well as valid url to confirm we're exercising both code paths.

Without this change we were seeing "82->76" in the missing code coverage, which means the code path where it's going from line 82 to line 76 wasn't covered. This now covers that.

[🤖 Canonical IS Merge Bot (canonical-is-mergebot)]

This merge proposal is being monitored by mergebot. Change the status to Approved to merge.

[Gareth Woolridge (moon127)]

LGTM!

review: Approve

[🤖 Canonical IS Merge Bot (canonical-is-mergebot)]

Change successfully merged at revision df3e5b21613a6da63677cce9e0a7bdc49034b329

diff --git a/tests/unit/test_charm.py b/tests/unit/test_charm.py
index d3e787a..42b6066 100644
--- a/tests/unit/test_charm.py
+++ b/tests/unit/test_charm.py
@@ -85,6 +85,13 @@ CONFIG_INVALID_EXTRA_CONFIG_NO_IMAGE = {
                       up_unifi_controller_1_pass=unifipoller, influx_interval=60s]",
 }
 
+# The first entry is valid, the second isn't, to ensure we exercise the
+# code path where we're not appending to errors for an invalid url.scheme
+# or missing url.netloc, as well as when we are appending errors.
+CONFIG_INVALID_EXTRA_CONFIG_NO_NETLOC = {
+    'extra_configs': "[up_unifi_controller_1_url=http://valid-url, up_unifi_controller_2_url=https:no-netloc]",
+}
+
 
 class TestCharm(unittest.TestCase):
     def setUp(self):
@@ -111,6 +118,9 @@ class TestCharm(unittest.TestCase):
         self.harness.update_config(CONFIG_INVALID_EXTRA_CONFIG)
         expected = 'invalid extra_config setting(s): influx_interval, up_unifi_controller_1_url'
         self.assertEqual(self.harness.charm._check_for_config_problems(), expected)
+        self.harness.update_config(CONFIG_INVALID_EXTRA_CONFIG_NO_NETLOC)
+        expected = 'invalid extra_config setting(s): up_unifi_controller_2_url'
+        self.assertEqual(self.harness.charm._check_for_config_problems(), expected)
 
     def test_check_for_missing_image_invalid_extra_config(self):
         """Check for correctly reports invalid extra_configs options."""