Merge ~mthaddon/charm-k8s-mattermost/+git/charm-k8s-mattermost:test-make-pod-config into charm-k8s-mattermost:master

[Tom Haddon]

Add tests for the make_pod_config function

Add tests for the make_pod_config function

[🤖 Canonical IS Merge Bot (canonical-is-mergebot)]

This merge proposal is being monitored by mergebot. Change the status to Approved to merge.

[🤖 prod-jenkaas-is (prod-jenkaas-is)]

A CI job is currently in progress. A follow up comment will be added when it completes.

[🤖 prod-jenkaas-is (prod-jenkaas-is)]

PASSED: Continuous integration, rev:e877f842fc26fe223404a78277650d171262936f
https://jenkins.canonical.com/is/job/lp-charm-k8s-mattermost-ci/2/
Executed test runs:
    SUCCESS: https://jenkins.canonical.com/is/job/lp-charm-test/26/
    None: https://jenkins.canonical.com/is/job/lp-update-mp/23920/

Click here to trigger a rebuild:
https://jenkins.canonical.com/is/job/lp-charm-k8s-mattermost-ci/2//rebuild

review: Approve (continuous-integration)

[Barry Price (barryprice)]

LGTM +1

review: Approve

[🤖 Canonical IS Merge Bot (canonical-is-mergebot)]

Change successfully merged at revision 9eebaf68b99783debe3b0c28fe6f38abf5ba135d

diff --git a/tests/unit/test_charm.py b/tests/unit/test_charm.py
index 1d3019b..44bee1f 100644
--- a/tests/unit/test_charm.py
+++ b/tests/unit/test_charm.py
@@ -121,6 +121,38 @@ class TestMattermostK8sCharmHooksDisabled(unittest.TestCase):
         )
         self.assertEqual(self.harness.charm._check_for_config_problems(), expected)
 
+    def test_make_pod_config(self):
+        """Make pod config."""
+        self.harness.charm.state.db_uri = 'postgresql://10.0.1.101:5432/'
+        expected = {
+            'MATTERMOST_HTTPD_LISTEN_PORT': 8065,
+            'MM_CONFIG': 'postgres://10.0.1.101:5432/',
+            'MM_IMAGEPROXYSETTINGS_ENABLE': 'false',
+            'MM_IMAGEPROXYSETTINGS_IMAGEPROXYTYPE': 'local',
+            'MM_LOGSETTINGS_CONSOLELEVEL': 'INFO',
+            'MM_LOGSETTINGS_ENABLECONSOLE': 'true',
+            'MM_LOGSETTINGS_ENABLEFILE': 'false',
+            'MM_SQLSETTINGS_DATASOURCE': 'postgres://10.0.1.101:5432/',
+        }
+        self.assertEqual(self.harness.charm._make_pod_config(), expected)
+        # Now test with `primary_team` set.
+        self.harness.update_config({"primary_team": "myteam"})
+        expected['MM_TEAMSETTINGS_EXPERIMENTALPRIMARYTEAM'] = "myteam"
+        self.assertEqual(self.harness.charm._make_pod_config(), expected)
+        # Now test with `site_url` set.
+        self.harness.update_config({"site_url": "myteam.mattermost.io"})
+        expected['MM_SERVICESETTINGS_SITEURL'] = "myteam.mattermost.io"
+        self.assertEqual(self.harness.charm._make_pod_config(), expected)
+        # Now test with `outbound_proxy` set.
+        self.harness.update_config({"outbound_proxy": "http://squid.internal:3128"})
+        expected['HTTP_PROXY'] = "http://squid.internal:3128"
+        expected['HTTPS_PROXY'] = "http://squid.internal:3128"
+        self.assertEqual(self.harness.charm._make_pod_config(), expected)
+        # Now test with `outbound_proxy_exceptions` set.
+        self.harness.update_config({"outbound_proxy_exceptions": "charmhub.io"})
+        expected['NO_PROXY'] = "charmhub.io"
+        self.assertEqual(self.harness.charm._make_pod_config(), expected)
+
     def test_make_s3_pod_config(self):
         """Make s3 pod config."""
         self.harness.update_config(CONFIG_NO_S3_SETTINGS_S3_ENABLED)