Merge ~mthaddon/charm-k8s-mattermost/+git/charm-k8s-mattermost:tests into charm-k8s-mattermost:master
Proposed by
Tom Haddon
Status: | Merged |
---|---|
Approved by: | Tom Haddon |
Approved revision: | 8c23ef87c9c237f0d000f7601402b2393f559c1e |
Merged at revision: | cda8e5377822ee813691ec45405662f9b0214642 |
Proposed branch: | ~mthaddon/charm-k8s-mattermost/+git/charm-k8s-mattermost:tests |
Merge into: | charm-k8s-mattermost:master |
Diff against target: |
62 lines (+38/-2) 2 files modified
src/charm.py (+1/-2) tests/unit/test_charm.py (+37/-0) |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Paul Collins | Approve | ||
Haw Loeung | +1 | Approve | |
Review via email: mp+391372@code.launchpad.net |
Commit message
Add some more tests for ingress conditions, remove conditional for annotations, which is always True in _update_
Description of the change
Add some more tests for ingress conditions, remove conditional for annotations, which is always True in _update_
Takes overall test coverage from 60% to 61%...
To post a comment you must log in.
This merge proposal is being monitored by mergebot. Change the status to Approved to merge.