Merge ~mthaddon/charm-k8s-mattermost/+git/charm-k8s-mattermost:flake8-version-string into charm-k8s-mattermost:master

Proposed by Tom Haddon
Status: Merged
Approved by: Paul Collins
Approved revision: 50431dac73af020a851382878ad211a973b32e12
Merged at revision: 7f40c1a6b0696aac398b7dca3cc7539ead1d35b2
Proposed branch: ~mthaddon/charm-k8s-mattermost/+git/charm-k8s-mattermost:flake8-version-string
Merge into: charm-k8s-mattermost:master
Diff against target: 15 lines (+2/-1)
1 file modified
tox.ini (+2/-1)
Reviewer Review Type Date Requested Status
Paul Collins Approve
Canonical IS Reviewers Pending
Review via email: mp+385909@code.launchpad.net

Commit message

Bionic doesn't like spaces in version strings in tox lp#1883884

Description of the change

Bionic doesn't like spaces in version strings in tox lp#1883884

To post a comment you must log in.
Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote :

This merge proposal is being monitored by mergebot. Change the status to Approved to merge.

Revision history for this message
John A Meinel (jameinel) wrote :

Note that on my system, it doesn't like any extra content, so it needs to be:
[testenv:lint]
commands = flake8 src/ tests/
deps =
    flake8==3.7.9

With
[testenv:lint]
commands = flake8 src/ tests/
deps =
    flake8==3.7.9 # to match focal

it still fails

Revision history for this message
Tom Haddon (mthaddon) wrote :

I've tested this in a bionic LXC as well as on focal, fwiw.

Revision history for this message
Paul Collins (pjdc) :
review: Approve
Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote :

Change successfully merged at revision 7f40c1a6b0696aac398b7dca3cc7539ead1d35b2

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/tox.ini b/tox.ini
2index 117984d..bfa2335 100644
3--- a/tox.ini
4+++ b/tox.ini
5@@ -34,8 +34,9 @@ deps = black
6
7 [testenv:lint]
8 commands = flake8 src/ tests/
9+# Pin flake8 to 3.7.9 to match focal
10 deps =
11- flake8 == 3.7.9 # to match focal
12+ flake8==3.7.9
13
14 [flake8]
15 exclude =

Subscribers

People subscribed via source and target branches