Merge ~mthaddon/charm-k8s-ingress/+git/charm-k8s-ingress:document-init-requires into charm-k8s-ingress:master
Proposed by
Tom Haddon
Status: | Merged |
---|---|
Approved by: | Jon Seager |
Approved revision: | eda7700ea14993c9a3c361d19bb4930164e88c27 |
Merged at revision: | 4b507f07402a1ac49c761705b3622c296965ba21 |
Proposed branch: | ~mthaddon/charm-k8s-ingress/+git/charm-k8s-ingress:document-init-requires |
Merge into: | charm-k8s-ingress:master |
Diff against target: |
24 lines (+6/-1) 1 file modified
lib/charms/nginx_ingress_integrator/v0/ingress.py (+6/-1) |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
🤖 prod-jenkaas-is (community) | continuous-integration | Approve | |
Benjamin Allot | Approve | ||
ingress-charmers | Pending | ||
Review via email: mp+403034@code.launchpad.net |
Commit message
Clarify that the IngressRequires class must be instantiated in __init__
To post a comment you must log in.
A CI job is currently in progress. A follow up comment will be added when it completes.