Merge ~mthaddon/charm-k8s-ingress/+git/charm-k8s-ingress:deploy-from-charmhub into charm-k8s-ingress:master

Proposed by Tom Haddon
Status: Merged
Approved by: Jon Seager
Approved revision: 27a1de98385885dec2c91c1727ffdb97df3f37ec
Merged at revision: 482c095489fef0e4c3852cc0967e9f4595339117
Proposed branch: ~mthaddon/charm-k8s-ingress/+git/charm-k8s-ingress:deploy-from-charmhub
Merge into: charm-k8s-ingress:master
Diff against target: 58 lines (+6/-14)
2 files modified
README.md (+4/-12)
lib/charms/nginx_ingress_integrator/v0/ingress.py (+2/-2)
Reviewer Review Type Date Requested Status
ingress-charmers Pending
Review via email: mp+401555@code.launchpad.net

Commit message

We can now deploy from charmhub direct

To post a comment you must log in.
Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote :

This merge proposal is being monitored by mergebot. Change the status to Approved to merge.

Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote :

Merge proposal is approved, but source revision has changed, setting status to needs review.

Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote :

Change successfully merged at revision 482c095489fef0e4c3852cc0967e9f4595339117

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/README.md b/README.md
2index 9f2052b..d156990 100644
3--- a/README.md
4+++ b/README.md
5@@ -10,20 +10,12 @@ size, etc.).
6
7 ## Usage
8
9-This charm needs to be built locally as charmhub.io can't yet host charms with
10-"bases" in `metadata.yaml`. Once that's been added, deployment instructions
11-will be updated, but for now, see the "Running the charm locally" section
12-below.
13-
14-## Running the charm locally
15-
16-To build the charm, run `charmcraft build`.
17-
18 You'll need version to be using Juju [version 2.9-rc11](https://discourse.charmhub.io/t/juju-2-9-rc11-release-notes/4501) or later.
19
20-As an example, you could deploy this charm as follows:
21+As an example, you could deploy this charm as follows (we're using the name
22+"ingress" in this model for brevity):
23 ```
24-juju deploy ./nginx-ingress-integrator.charm ingress --resource placeholder-image=google/pause
25+juju deploy nginx-ingress-integrator ingress
26 ```
27 To create an ingress for your service, you'd then add a relation to a charm
28 that supports the `ingress` relation. As an example:
29@@ -67,7 +59,7 @@ can still override the configuration of the ingress using Juju config. Using
30 the above example, where your charm sets the `service-port` as "80" in the
31 relation, you could override this by doing the following:
32 ```
33-juju deploy ./nginx-ingress-integrator.charm ingress --resource placeholder-image='google/pause' --config kube-config="$(microk8s config)"
34+juju deploy nginx-ingress-integrator ingress
35 juju deploy ./gunicorn.charm --resource gunicorn-image='gunicorncharmers/gunicorn-app:edge'
36 juju relate ingress gunicorn
37 juju config ingress service-port=8080
38diff --git a/lib/charms/nginx_ingress_integrator/v0/ingress.py b/lib/charms/nginx_ingress_integrator/v0/ingress.py
39index a935d5a..066b257 100644
40--- a/lib/charms/nginx_ingress_integrator/v0/ingress.py
41+++ b/lib/charms/nginx_ingress_integrator/v0/ingress.py
42@@ -19,7 +19,7 @@ Import `IngressRequires` in your charm, with two required options:
43 - session-cookie-max-age
44 - tls-secret-name
45
46-See `config.yaml` for descriptions of each, along with the required type.
47+See [the config section](https://charmhub.io/nginx-ingress-integrator/configure) for descriptions of each, along with the required type.
48
49 As an example, add the following to `src/charm.py`:
50 ```
51@@ -55,7 +55,7 @@ LIBAPI = 0
52
53 # Increment this PATCH version before using `charmcraft publish-lib` or reset
54 # to 0 if you are raising the major API version
55-LIBPATCH = 3
56+LIBPATCH = 4
57
58 logger = logging.getLogger(__name__)
59

Subscribers

People subscribed via source and target branches

to all changes: