Merge ~mthaddon/charm-k8s-ingress/+git/charm-k8s-ingress:readme-release-candidate into charm-k8s-ingress:master

Proposed by Tom Haddon
Status: Merged
Approved by: Jon Seager
Approved revision: 469ec118316325b985d061508daa6273a3408e14
Merged at revision: c004e056dafd4754653d2cfc8acf4168f62105d4
Proposed branch: ~mthaddon/charm-k8s-ingress/+git/charm-k8s-ingress:readme-release-candidate
Merge into: charm-k8s-ingress:master
Diff against target: 23 lines (+1/-10)
1 file modified
README.md (+1/-10)
Reviewer Review Type Date Requested Status
🤖 prod-jenkaas-is (community) continuous-integration Approve
ingress-charmers Pending
Review via email: mp+400452@code.launchpad.net

Commit message

We can use Juju 2.9-rc8 or later, update README to reflect this

To post a comment you must log in.
Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote :

This merge proposal is being monitored by mergebot. Change the status to Approved to merge.

Revision history for this message
🤖 prod-jenkaas-is (prod-jenkaas-is) wrote :

A CI job is currently in progress. A follow up comment will be added when it completes.

Revision history for this message
🤖 prod-jenkaas-is (prod-jenkaas-is) wrote :

PASSED: Continuous integration, rev:469ec118316325b985d061508daa6273a3408e14
https://jenkins.canonical.com/is/job/lp-charm-k8s-ingress-ci/17/
Executed test runs:
    SUCCESS: https://jenkins.canonical.com/is/job/lp-charm-test/49/
    None: https://jenkins.canonical.com/is/job/lp-update-mp/61325/

Click here to trigger a rebuild:
https://jenkins.canonical.com/is/job/lp-charm-k8s-ingress-ci/17//rebuild

review: Approve (continuous-integration)
Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote :

Change successfully merged at revision c004e056dafd4754653d2cfc8acf4168f62105d4

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/README.md b/README.md
2index d1dc427..f98aad4 100644
3--- a/README.md
4+++ b/README.md
5@@ -19,17 +19,8 @@ below.
6
7 To build the charm, run `charmcraft build`.
8
9-You'll need version 1.14 or later of Go (`go version` will confirm your current version), and a custom version of the Juju 2.9 branch, as below:
10+You'll need version to be using Juju [version 2.9-rc8](https://discourse.charmhub.io/t/juju-2-9-rc8-release-notes/4394/) or later.
11
12-```
13-git clone -b 2.9 https://github.com/juju/juju
14-cd juju
15-make install
16-make microk8s-operator-update # to make the microk8s image and push to Docker
17-export PATH="/home/${USER}/go/bin:$PATH"
18-juju bootstrap microk8s --no-gui
19-juju add-model ingress-test
20-```
21 Once https://bugs.launchpad.net/juju/+bug/1920102 has been addressed, this
22 charm will be able to use the credentials provided in cluster. However, for
23 now, you will need to provide this charm with credentials to be able to talk

Subscribers

People subscribed via source and target branches

to all changes: