Merge ~mthaddon/charm-k8s-discourse/+git/charm-k8s-discourse:charmcraft-yaml into charm-k8s-discourse:master

Proposed by Tom Haddon
Status: Merged
Merged at revision: c6cb23e62b03e1253f9fffcc3103d551c50e12d8
Proposed branch: ~mthaddon/charm-k8s-discourse/+git/charm-k8s-discourse:charmcraft-yaml
Merge into: charm-k8s-discourse:master
Diff against target: 61 lines (+10/-9)
3 files modified
Makefile (+1/-6)
charmcraft.yaml (+8/-0)
tox.ini (+1/-3)
Reviewer Review Type Date Requested Status
🤖 prod-jenkaas-is (community) continuous-integration Needs Fixing
Canonical IS Reviewers Pending
Discourse Charm Maintainers Pending
Review via email: mp+411514@code.launchpad.net

Commit message

Add a charmcraft.yaml and update path for tox

To post a comment you must log in.
Revision history for this message
🤖 prod-jenkaas-is (prod-jenkaas-is) wrote :

A CI job is currently in progress. A follow up comment will be added when it completes.

Revision history for this message
🤖 prod-jenkaas-is (prod-jenkaas-is) wrote :

FAILED: Continuous integration, rev:bb013da16c36c83dfa103d472fe21eac40d84a94

No commit message was specified in the merge proposal. Click on the following link and set the commit message (if you want jenkins to rebuild you need to trigger it yourself):
https://code.launchpad.net/~mthaddon/charm-k8s-discourse/+git/charm-k8s-discourse/+merge/411514/+edit-commit-message

https://jenkins.canonical.com/is/job/lp-charm-k8s-discourse-ci/34/
Executed test runs:
    SUCCESS: https://jenkins.canonical.com/is/job/lp-charm-test/149/
    None: https://jenkins.canonical.com/is/job/lp-update-mp/538387/

Click here to trigger a rebuild:
https://jenkins.canonical.com/is/job/lp-charm-k8s-discourse-ci/34//rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote :

This merge proposal is being monitored by mergebot. Change the status to Approved to merge.

Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote :

Unable to determine commit message from repository - please click "Set commit message" and enter the commit message manually.

Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote :

Failed to merge change (unable to merge source repository due to conflicts), setting status to needs review.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/Makefile b/Makefile
2index d754dab..f4d845e 100644
3--- a/Makefile
4+++ b/Makefile
5@@ -10,9 +10,7 @@ lint: blacken
6 @echo "Running flake8"
7 @tox -e lint
8
9-# We actually use the build directory created by charmcraft,
10-# but the .charm file makes a much more convenient sentinel.
11-unittest: discourse-k8s.charm
12+unittest:
13 @tox -e unit
14
15 test: lint unittest
16@@ -21,9 +19,6 @@ clean:
17 @echo "Cleaning files"
18 @git clean -fXd
19
20-discourse-k8s.charm: src/*.py requirements.txt
21- charmcraft build
22-
23 build-image:
24 @echo "Building the image."
25 @docker build \
26diff --git a/charmcraft.yaml b/charmcraft.yaml
27new file mode 100644
28index 0000000..bf04cb1
29--- /dev/null
30+++ b/charmcraft.yaml
31@@ -0,0 +1,8 @@
32+type: charm
33+bases:
34+ - build-on:
35+ - name: "ubuntu"
36+ channel: "20.04"
37+ run-on:
38+ - name: "ubuntu"
39+ channel: "20.04"
40diff --git a/tox.ini b/tox.ini
41index d48b030..3d6bf55 100644
42--- a/tox.ini
43+++ b/tox.ini
44@@ -5,8 +5,6 @@ skip_missing_interpreters = True
45
46 [testenv]
47 basepython = python3
48-setenv =
49- PYTHONPATH = {toxinidir}/build/lib:{toxinidir}/build/venv
50
51 [testenv:unit]
52 commands =
53@@ -15,7 +13,7 @@ commands =
54 deps = -r{toxinidir}/tests/unit/requirements.txt
55 -r{toxinidir}/requirements.txt
56 setenv =
57- PYTHONPATH={toxinidir}/src:{toxinidir}/build/lib:{toxinidir}/build/venv
58+ PYTHONPATH = {toxinidir}/lib:{toxinidir}/src
59 TZ=UTC
60
61 [testenv:black]

Subscribers

People subscribed via source and target branches