Charm Helpers

Merge lp:~mthaddon/charm-helpers/test-dot-upper-case-service-names into lp:charm-helpers

  1. test-dot-upper-case-service-names
  2. Merge into devel
Proposed by Tom Haddon
Status: Merged
Merged at revision: 774
Proposed branch: lp:~mthaddon/charm-helpers/test-dot-upper-case-service-names
Merge into: lp:charm-helpers
Diff against target: 13 lines (+2/-0)
1 file modified
tests/contrib/charmsupport/test_nrpe.py (+2/-0)
To merge this branch: bzr merge lp:~mthaddon/charm-helpers/test-dot-upper-case-service-names
Reviewer Review Type Date Requested Status
Stuart Bishop (community) Approve
Review via email: mp+328332@code.launchpad.net

Description of the change

Add checks for dots and upper case in service names

To post a comment you must log in.
Revision history for this message
Stuart Bishop (stub) wrote :

Yup

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'tests/contrib/charmsupport/test_nrpe.py'
2--- tests/contrib/charmsupport/test_nrpe.py 2017-07-30 22:46:11 +0000
3+++ tests/contrib/charmsupport/test_nrpe.py 2017-07-31 19:05:02 +0000
4@@ -197,7 +197,9 @@
5 def test_valid_shortname(self):
6 cases = [
7 '1_number_is_fine',
8+ 'dots.are.good',
9 'dashes-ok',
10+ 'UPPER_case_allowed',
11 '5',
12 ]
13 for shortname in cases:

Subscribers

People subscribed via source and target branches