Merge lp:~mthaddon/charm-haproxy/jammy into lp:charm-haproxy

Proposed by Tom Haddon
Status: Merged
Approved by: Haw Loeung
Approved revision: 155
Merged at revision: 155
Proposed branch: lp:~mthaddon/charm-haproxy/jammy
Merge into: lp:charm-haproxy
Diff against target: 42 lines (+6/-3)
3 files modified
charmcraft.yaml (+2/-0)
hooks/hooks.py (+3/-3)
metadata.yaml (+1/-0)
To merge this branch: bzr merge lp:~mthaddon/charm-haproxy/jammy
Reviewer Review Type Date Requested Status
Haw Loeung +1 Approve
Canonical IS Reviewers Pending
Review via email: mp+446763@code.launchpad.net

Commit message

Add support for jammy

Description of the change

Add support for jammy.

I've done a test install of all supported series, and then also confirmed I can relate the new pollen charm to the HAProxy charm on jammy and can query both:

```
mthaddon@finistere:~/repos/haproxy-charm/charm-haproxy$ pollinate -i -s http://10.46.16.58:80 -t
<13>Jul 13 11:57:44 pollinate[1641944]: client sent challenge to [http://10.46.16.58:80]
<13>Jul 13 11:57:44 pollinate[1641944]: client verified challenge/response with [http://10.46.16.58:80]
�!ȹ��
�E������W�<QQ^Ȥ���%��lxg��&�$�ׄ�Y�(�àH2�]J<13>Jul 13 11:57:44 pollinate[1641944]: client hashed response from [http://10.46.16.58:80]
<13>Jul 13 11:57:44 pollinate[1641944]: client successfully seeded [-]
mthaddon@finistere:~/repos/haproxy-charm/charm-haproxy$ # That's jammy
mthaddon@finistere:~/repos/haproxy-charm/charm-haproxy$ pollinate -i -s http://10.46.16.213:8080 -t
<13>Jul 13 11:57:59 pollinate[1642040]: client sent challenge to [http://10.46.16.213:8080]
<13>Jul 13 11:57:59 pollinate[1642040]: client verified challenge/response with [http://10.46.16.213:8080]
)8�U��~��4D���0�$m�<�/:ѾnIN�$-4JM+⨷4�ך�A��G]���"N��g��<13>Jul 13 11:57:59 pollinate[1642040]: client hashed response from [http://10.46.16.213:8080]
<13>Jul 13 11:57:59 pollinate[1642040]: client successfully seeded [-]
mthaddon@finistere:~/repos/haproxy-charm/charm-haproxy$ # And that's the pollen unit
mthaddon@finistere:~/repos/haproxy-charm/charm-haproxy$ juju status
Model Controller Cloud/Region Version SLA Timestamp
default localhost-localhost localhost/localhost 2.9.43 unsupported 11:59:15+02:00

App Version Status Scale Charm Channel Rev Exposed Message
bionic active 1 haproxy 0 no Unit is ready
focal active 1 haproxy 0 no Unit is ready
jammy active 1 haproxy 0 no Unit is ready
pollen active 1 pollen edge 3 no
xenial active 1 haproxy 0 no Unit is ready

Unit Workload Agent Machine Public address Ports Message
bionic/0* active idle 1 10.46.16.31 Unit is ready
focal/0* active idle 2 10.46.16.176 Unit is ready
jammy/0* active idle 3 10.46.16.58 80/tcp Unit is ready
pollen/0* active idle 4 10.46.16.213
xenial/0* active idle 0 10.46.16.28 Unit is ready

Machine State Address Inst id Series AZ Message
0 started 10.46.16.28 juju-72706c-0 xenial Running
1 started 10.46.16.31 juju-72706c-1 bionic Running
2 started 10.46.16.176 juju-72706c-2 focal Running
3 started 10.46.16.58 juju-72706c-3 jammy Running
4 started 10.46.16.213 juju-72706c-4 jammy Running

mthaddon@finistere:~/repos/haproxy-charm/charm-haproxy$
```

To post a comment you must log in.
Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote :

This merge proposal is being monitored by mergebot. Change the status to Approved to merge.

Revision history for this message
Haw Loeung (hloeung) wrote :

LGTM

review: Approve (+1)
Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote :

Change successfully merged at revision 155

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'charmcraft.yaml'
2--- charmcraft.yaml 2023-07-12 12:08:59 +0000
3+++ charmcraft.yaml 2023-07-13 10:00:42 +0000
4@@ -5,6 +5,8 @@
5 channel: "20.04"
6 run-on:
7 - name: "ubuntu"
8+ channel: "22.04"
9+ - name: "ubuntu"
10 channel: "20.04"
11 - name: "ubuntu"
12 channel: "18.04"
13
14=== modified file 'hooks/hooks.py'
15--- hooks/hooks.py 2023-07-12 12:08:59 +0000
16+++ hooks/hooks.py 2023-07-13 10:00:42 +0000
17@@ -977,10 +977,10 @@
18 add_backports_preferences(release)
19 add_source(source, config_data.get('key'))
20 apt_update(fatal=True)
21- apt_install(['haproxy', 'python-jinja2'], fatal=True)
22+ apt_install(['haproxy', 'python3-jinja2'], fatal=True)
23 # Install pyasn1 library and modules for inspecting SSL certificates
24- pkgs = ['python-pyasn1', 'python-pyasn1-modules', 'python-apt',
25- 'python-openssl']
26+ pkgs = ['python3-pyasn1', 'python3-pyasn1-modules', 'python3-apt',
27+ 'python3-openssl']
28 apt_install(filter_installed_packages(pkgs), fatal=False)
29 ensure_package_status(service_affecting_packages, config_data['package_status'])
30 enable_haproxy()
31
32=== modified file 'metadata.yaml'
33--- metadata.yaml 2023-07-13 06:40:57 +0000
34+++ metadata.yaml 2023-07-13 10:00:42 +0000
35@@ -12,6 +12,7 @@
36 tags: ["cache-proxy"]
37 series:
38 - focal
39+ - jammy
40 - bionic
41 - xenial
42 requires:

Subscribers

People subscribed via source and target branches

to all changes: