Merge ~mthaddon/apache2-charm/+git/apache2-charm:readme-easier-deploy into apache2-charm:master

Proposed by Tom Haddon
Status: Merged
Approved by: Tom Haddon
Approved revision: dc4fc700e299ab3c2618876e94b722da8c1de8d2
Merged at revision: 521e71dff0f9ef083d1ac74fd9de0500eae1a1f4
Proposed branch: ~mthaddon/apache2-charm/+git/apache2-charm:readme-easier-deploy
Merge into: apache2-charm:master
Diff against target: 94 lines (+28/-35)
1 file modified
README.md (+28/-35)
Reviewer Review Type Date Requested Status
Loïc Gomez Approve
Canonical IS Reviewers Pending
Review via email: mp+408807@code.launchpad.net

Commit message

Move the development section to the end of the README, simplify deployment instructions

To post a comment you must log in.
Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote :

This merge proposal is being monitored by mergebot. Change the status to Approved to merge.

Revision history for this message
Loïc Gomez (kotodama) wrote :

+1

review: Approve
Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote :

Change successfully merged at revision 521e71dff0f9ef083d1ac74fd9de0500eae1a1f4

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/README.md b/README.md
2index f5876f1..720ab56 100644
3--- a/README.md
4+++ b/README.md
5@@ -8,54 +8,28 @@ CGI, SSI, IPv6, easy scripting and database integration,
6 request/response filtering, many flexible authentication schemes,
7 and more.
8
9-## Development
10-
11-
12-The following steps are needed for testing and development of the
13-charm, but **not** for deployment:
14-
15- sudo apt-get install python-software-properties
16- sudo add-apt-repository ppa:chrisjohnston/flake8
17- sudo apt-get update
18- sudo apt-get install python-flake8 python-nose python-coverage \
19- python-testtools python-pyasn1 python-pyasn1-modules
20-
21-To fetch additional source dependencies and run the tests:
22-
23- make build
24-
25-... will run the unit tests, run flake8 over the source to warn
26-about formatting issues and output a code coverage summary of the
27-'hooks.py' module.
28-
29 ## How to deploy the charm
30
31-Assuming you have a copy of the charm into a `charms/$distrocodename/apache2`
32-directory relative to your current directory.
33-
34-... then to perform a deployment execute the following steps:
35-
36- juju deploy --repository=charms local:apache2
37- juju set apache2 "vhost_http_template=$(base64 < http_vhost.tmpl)"
38-
39+ juju deploy apache2
40+ juju config apache2 "vhost_http_template=$(base64 < http_vhost.tmpl)"
41
42 # and / or
43- juju set apache2 "vhost_https_template=$(base64 < https_vhost.tmpl)"
44+ juju config apache2 "vhost_https_template=$(base64 < https_vhost.tmpl)"
45
46 If you want a simple `reverseproxy` relation to your services (only
47 really useful if you have a single unit on the other side of the
48 relation):
49
50- juju add-relation apache2:reverseproxy haproxy:website
51+ juju relate apache2:reverseproxy haproxy:website
52 # and / or
53- juju add-relation apache2:reverseproxy squid-reverseproxy:cached-website
54+ juju relate apache2:reverseproxy squid-reverseproxy:cached-website
55
56 Alternatively, you can use the `balancer` relation so that requests
57 are load balanced across multiple units of your services. For more information see the section on `Using the balancer relation`:
58
59- juju add-relation apache2:balancer haproxy:website
60+ juju relate apache2:balancer haproxy:website
61 # and / or
62- juju add-relation apache2:balancer squid-reverseproxy:cached-website
63+ juju relate apache2:balancer squid-reverseproxy:cached-website
64
65 ## VirtualHost templates
66
67@@ -322,6 +296,25 @@ apache_openid
68 * Tuning. No tuning options are present. Convert apache2.conf to a
69 template and expose config options
70
71- * The all_services variable can be passed as part of the http interface and is
72+ * The `all_services` variable can be passed as part of the http interface and is
73 optional. However its kind of secret and it would be more obvious if a
74- seperate interface was used like http-allservices.
75+ separate interface was used like http-allservices.
76+
77+## Development
78+
79+The following steps are needed for testing and development of the
80+charm, but **not** for deployment:
81+
82+ sudo apt-get install python-software-properties
83+ sudo add-apt-repository ppa:chrisjohnston/flake8
84+ sudo apt-get update
85+ sudo apt-get install python-flake8 python-nose python-coverage \
86+ python-testtools python-pyasn1 python-pyasn1-modules
87+
88+To fetch additional source dependencies and run the tests:
89+
90+ make build
91+
92+... will run the unit tests, run flake8 over the source to warn
93+about formatting issues and output a code coverage summary of the
94+'hooks.py' module.

Subscribers

People subscribed via source and target branches

to all changes: