Code review comment for lp:~mterry/webbrowser-app/less-ubuntucolors

Revision history for this message
Michael Terry (mterry) wrote :

- Made the OK button green in ConfirmDialog and AlertDialog.

- Looking at BeforeUnloadDialog, I thought it made sense to make "Leave" red and keep "Stay" grey. Let me know if you don't like this.

- For the history/bookmark views... at least in the current theme shipped today, selected.backgroundText is the same as normal.backgroundText: UbuntuColors.jet. Maybe that's a bug with the theme...? But I don't think positionText is so wrong. It's supposed to be "applied to navigation elements to indicate current position" (from PaletteValues.qml). And it's the color used in the toolkit's SectionsStyle.qml to indicate which header section is active. So maybe that spec is out of date? I think positionText is a relatively new palette option.

- Updated copyrights.

« Back to merge proposal