Merge lp:~mterry/unity8/we-are-at-least-beta into lp:unity8

Proposed by Michael Terry
Status: Merged
Approved by: Michael Zanetti
Approved revision: 1435
Merged at revision: 1444
Proposed branch: lp:~mterry/unity8/we-are-at-least-beta
Merge into: lp:unity8
Diff against target: 31 lines (+1/-17)
1 file modified
qml/Shell.qml (+1/-17)
To merge this branch: bzr merge lp:~mterry/unity8/we-are-at-least-beta
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Needs Fixing
Michael Zanetti (community) Approve
Review via email: mp+241615@code.launchpad.net

Commit message

Drop the "EARLY ALPHA" scare label when running in testing mode.

A) We are past early alpha stages by this point.
B) It's distracting when trying to test unity8. I doubt anyone that is running "./run.sh -f" really needs to be reminded that they are testing it.

Description of the change

Drop the "EARLY ALPHA" scare label when running in testing mode.

A) We are past early alpha stages by this point.
B) It's distracting when trying to test unity8. I doubt anyone that is running "./run.sh -f" really needs to be reminded that they are testing it.

== Checklist ==

 * Are there any related MPs required for this MP to build/function as expected? Please list.
 No

 * Did you perform an exploratory manual test run of your code change and any related functionality?
 Yes

 * Did you make sure that your branch does not contain spurious tags?
 Yes

 * If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?
 NA

 * If you changed the UI, has there been a design review?
 NA

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Michael Zanetti (mzanetti) wrote :

> * Did you make sure that your branch does not contain spurious tags?
> Yes

Did you really? :P

review: Needs Fixing
Revision history for this message
Michael Terry (mterry) wrote :

Tags should be fixed.

Revision history for this message
Michael Zanetti (mzanetti) wrote :

hmm... seems they are fixed a bit too much... don't have a single tag around any more after freshly checking out that branch.

1435. By Michael Terry

Merge from trunk

Revision history for this message
Michael Zanetti (mzanetti) wrote :

I for one am not sure if we really are beta on the desktop already. However, this text is only triggered if we're using the fake application manager. Nowadays though, we're using QtMir in the desktop session too, so this shows up only when developing.

=> +1 on dropping it.

 * Did you perform an exploratory manual test run of the code change and any related functionality?

yes

 * Did CI run pass? If not, please explain why.

as much as it could. no issues introduced here.

 * Did you make sure that the branch does not contain spurious tags?

hell yeah, I did :D

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'qml/Shell.qml'
2--- qml/Shell.qml 2014-11-07 14:30:42 +0000
3+++ qml/Shell.qml 2014-11-13 15:09:10 +0000
4@@ -776,26 +776,10 @@
5 }
6 }
7
8- Label {
9- id: alphaDisclaimerLabel
10- anchors.centerIn: parent
11- visible: ApplicationManager.fake ? ApplicationManager.fake : false
12- z: dialogs.z + 10
13- text: "EARLY ALPHA\nNOT READY FOR USE"
14- color: "lightgrey"
15- opacity: 0.2
16- font.weight: Font.Black
17- horizontalAlignment: Text.AlignHCenter
18- verticalAlignment: Text.AlignVCenter
19- fontSizeMode: Text.Fit
20- rotation: -45
21- scale: Math.min(parent.width, parent.height) / width
22- }
23-
24 EdgeDemo {
25 id: edgeDemo
26 objectName: "edgeDemo"
27- z: alphaDisclaimerLabel.z + 10
28+ z: dialogs.z + 10
29 paused: Powerd.status === Powerd.Off // Saves power
30 greeter: greeter
31 launcher: launcher

Subscribers

People subscribed via source and target branches