lp:~mterry/unity8/unlock-sim-after-wizard

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp:unity8 at revision 1666

Michał Sawicz: Approve (functional) on 2015-03-11

Daniel d'Andrada (community): Approve (code) on 2015-03-11

PS Jenkins bot (community): Needs Fixing (continuous-integration) on 2015-03-10

Diff: 113 lines (+34/-6)

4 files modified

qml/Greeter/Greeter.qml (+0/-5)
qml/Shell.qml (+11/-0)
qml/Wizard/Wizard.qml (+6/-1)
tests/qmltests/tst_Shell.qml (+17/-0)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Bug #1425161: [Wizard] SIM PIN page before language selection

High

Fix Released

Link a bug report

Related blueprints

1639. By Michael Terry on 2015-03-11

Add some comments on why we cache the 'active' bool instead of using an alias

1638. By Michael Terry on 2015-03-10

Merge from unifyShellTests

1637. By Michael Terry on 2015-03-03

Merge unifyShellTests

1636. By Michael Terry on 2015-02-25

Only unlock modems after we're done with the wizard

1635. By CI Train Bot Account on 2015-02-24

Releasing 8.02+15.04.20150224-0ubuntu1

1634. By Albert Astals Cid on 2015-02-24

Fix some warnings in Mock Notifications

Approved by: Daniel d'Andrada

1633. By Albert Astals Cid on 2015-02-24

Do not declare the hostname property twice
Approved by: Michael Terry, Andrea Cimitan

1632. By Michael Terry on 2015-02-24

Wait for libqofono to finish initializing before we decide whether to skip the wizard's SIM page or not.

libqofono became asynchronous on its last upload (about a month ago), which the wizard was not prepared for. We didn't notice because our mocks continued their synchronous behavior, and in manual testing, it's easy to miss (you'd have to not have a SIM in, and then notice that you *didn't* get a screen).

I've updated our mock to be asynchronous (to get the desired signal timing behavior, I switched one of our mock classes to C++ from qml).

And I've added support for artificially extending the delays in the async flow. This lets us test those delays specifically. And obviously, I added a couple tests to do so. Fixes: #1423565
Approved by: Albert Astals Cid

1631. By Michael Terry on 2015-02-24

Silence a couple qml warnings. Fixes: #1423286
Approved by: Daniel d'Andrada

1630. By Michael Terry on 2015-02-24

Move the gschema file to data/ and install it via cmake, not dpkg.
Approved by: Albert Astals Cid