Merge lp:~mterry/unity8/tutorial-refactor into lp:unity8
| Status: | Superseded | ||||
|---|---|---|---|---|---|
| Proposed branch: | lp:~mterry/unity8/tutorial-refactor | ||||
| Merge into: | lp:unity8 | ||||
| Diff against target: |
3227 lines (+1582/-862) 41 files modified
debian/unity8.install (+1/-0) plugins/Ubuntu/Gestures/TouchGate.cpp (+2/-0) plugins/Ubuntu/Gestures/TouchGate.h (+2/-0) qml/CMakeLists.txt (+3/-2) qml/Components/EdgeDemo.qml (+0/-254) qml/Components/EdgeDemoOverlay.qml (+0/-273) qml/Launcher/Launcher.qml (+13/-7) qml/Shell.qml (+42/-23) qml/Stages/ApplicationWindow.qml (+3/-1) qml/Stages/PhoneStage.qml (+2/-0) qml/Stages/SessionContainer.qml (+24/-9) qml/Stages/SpreadDelegate.qml (+2/-1) qml/Stages/SurfaceContainer.qml (+11/-25) qml/Stages/TabletStage.qml (+14/-0) qml/Stages/TransformedTabletSpreadDelegate.qml (+1/-1) qml/Tutorial/Arrow.qml (+56/-0) qml/Tutorial/Slider.qml (+117/-0) qml/Tutorial/Tutorial.qml (+85/-0) qml/Tutorial/TutorialContent.qml (+130/-0) qml/Tutorial/TutorialLeft.qml (+91/-0) qml/Tutorial/TutorialLeftFinish.qml (+47/-0) qml/Tutorial/TutorialPage.qml (+240/-0) tests/autopilot/unity8/shell/emulators/tutorial.py (+16/-102) tests/autopilot/unity8/shell/fixture_setup.py (+6/-6) tests/autopilot/unity8/shell/tests/test_tutorial.py (+17/-18) tests/mocks/Unity/Application/MirSurfaceItem.qml (+16/-1) tests/qmltests/CMakeLists.txt (+2/-1) tests/qmltests/Components/tst_EdgeDemoOverlay.qml (+0/-123) tests/qmltests/Stages/ApplicationCheckBox.qml (+45/-0) tests/qmltests/Stages/RecursingChildSessionControl.qml (+3/-0) tests/qmltests/Stages/tst_ApplicationWindow.qml (+6/-1) tests/qmltests/Stages/tst_PhoneStage.qml (+4/-0) tests/qmltests/Stages/tst_SessionContainer.qml (+14/-7) tests/qmltests/Stages/tst_TabletStage.qml (+154/-0) tests/qmltests/Tutorial/tst_Tutorial.qml (+286/-0) tests/qmltests/tst_Shell.qml (+26/-5) tests/qmltests/tst_TabletShell.qml (+2/-2) tests/uqmlscene/ActiveFocusLogger.cpp (+48/-0) tests/uqmlscene/ActiveFocusLogger.h (+37/-0) tests/uqmlscene/CMakeLists.txt (+1/-0) tests/uqmlscene/main.cpp (+13/-0) |
||||
| To merge this branch: | bzr merge lp:~mterry/unity8/tutorial-refactor | ||||
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| PS Jenkins bot | continuous-integration | Approve on 2015-02-11 | |
| Andrea Cimitan (community) | 2014-10-28 | Approve on 2015-01-09 | |
|
Review via email:
|
|||
This proposal has been superseded by a proposal from 2015-02-11.
Commit Message
Redesign tutorial to match latest spec (just removing obsolete pages and redesigning look, no new pages yet)
Description of the Change
Redesign tutorial to match latest spec (just removing obsolete pages and redesigning look, no new pages yet)
Specifically, both the greeter and top-edge pages are dropped. Design decided they were self-explanatory enough that they didn't need to be part of the tutorial (in an effort to make it shorter).
The tutorial is still missing right-edge and bottom-edge pages. But since those are new, I am going to do them as a separate branch. This branch is just about trimming the tutorial and redesigning the look and feel.
This leaves us with a very short tutorial right now, but I'm OK with that. It will get longer in a moment with my next tutorial branch.
I did a whole refactor of the tutorial code while here. I didn't like the old way I had done it (too procedural rather than declarative).
I've also taken this opportunity to sync our technical name for the tutorial (edge demo) to what Design calls it (tutorial).
Here is the spec from Design:
https:/
== Checklist ==
* Are there any related MPs required for this MP to build/function as expected? Please list.
No
* Did you perform an exploratory manual test run of your code change and any related functionality?
Yes
* Did you make sure that your branch does not contain spurious tags?
Yes
* If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?
I'm in that team
* If you changed the UI, has there been a design review?
Yes-ish, they saw an earlier version, will get final approval.
| PS Jenkins bot (ps-jenkins) wrote : | # |
FAILED: Continuous integration, rev:1372
http://
Executed test runs:
FAILURE: http://
FAILURE: http://
FAILURE: http://
FAILURE: http://
FAILURE: http://
Click here to trigger a rebuild:
http://
| PS Jenkins bot (ps-jenkins) wrote : | # |
FAILED: Continuous integration, rev:1373
http://
Executed test runs:
FAILURE: http://
FAILURE: http://
FAILURE: http://
FAILURE: http://
FAILURE: http://
Click here to trigger a rebuild:
http://
| PS Jenkins bot (ps-jenkins) wrote : | # |
FAILED: Continuous integration, rev:1374
http://
Executed test runs:
UNSTABLE: http://
UNSTABLE: http://
SUCCESS: http://
SUCCESS: http://
UNSTABLE: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
Click here to trigger a rebuild:
http://
| Albert Astals Cid (aacid) wrote : | # |
Text conflict in qml/Shell.qml
Conflict adding file qml/Tutorial. Moved existing file to qml/Tutorial.moved.
Text conflict in qml/Tutorial/
3 conflicts encountered.
| PS Jenkins bot (ps-jenkins) wrote : | # |
FAILED: Continuous integration, rev:1377
http://
Executed test runs:
UNSTABLE: http://
UNSTABLE: http://
SUCCESS: http://
SUCCESS: http://
UNSTABLE: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
Click here to trigger a rebuild:
http://
| PS Jenkins bot (ps-jenkins) wrote : | # |
FAILED: Continuous integration, rev:1379
http://
Executed test runs:
UNSTABLE: http://
UNSTABLE: http://
SUCCESS: http://
SUCCESS: http://
UNSTABLE: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
Click here to trigger a rebuild:
http://
| PS Jenkins bot (ps-jenkins) wrote : | # |
FAILED: Continuous integration, rev:1379
http://
Executed test runs:
UNSTABLE: http://
UNSTABLE: http://
SUCCESS: http://
SUCCESS: http://
UNSTABLE: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
Click here to trigger a rebuild:
http://
| Albert Astals Cid (aacid) wrote : | # |
Text conflict in qml/Shell.qml
1 conflicts encountered.
| PS Jenkins bot (ps-jenkins) wrote : | # |
FAILED: Continuous integration, rev:1380
http://
Executed test runs:
SUCCESS: http://
SUCCESS: http://
FAILURE: http://
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
Click here to trigger a rebuild:
http://
| PS Jenkins bot (ps-jenkins) wrote : | # |
FAILED: Continuous integration, rev:1382
http://
Executed test runs:
SUCCESS: http://
UNSTABLE: http://
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
Click here to trigger a rebuild:
http://
| PS Jenkins bot (ps-jenkins) wrote : | # |
FAILED: Continuous integration, rev:1383
http://
Executed test runs:
UNSTABLE: http://
UNSTABLE: http://
SUCCESS: http://
SUCCESS: http://
UNSTABLE: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
Click here to trigger a rebuild:
http://
| PS Jenkins bot (ps-jenkins) wrote : | # |
FAILED: Continuous integration, rev:1384
http://
Executed test runs:
SUCCESS: http://
UNSTABLE: http://
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
Click here to trigger a rebuild:
http://
| PS Jenkins bot (ps-jenkins) wrote : | # |
FAILED: Continuous integration, rev:1385
http://
Executed test runs:
SUCCESS: http://
UNSTABLE: http://
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
Click here to trigger a rebuild:
http://
| PS Jenkins bot (ps-jenkins) wrote : | # |
PASSED: Continuous integration, rev:1386
http://
Executed test runs:
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
Click here to trigger a rebuild:
http://
| PS Jenkins bot (ps-jenkins) wrote : | # |
FAILED: Continuous integration, rev:1387
http://
Executed test runs:
UNSTABLE: http://
UNSTABLE: http://
SUCCESS: http://
SUCCESS: http://
UNSTABLE: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
Click here to trigger a rebuild:
http://
| PS Jenkins bot (ps-jenkins) wrote : | # |
PASSED: Continuous integration, rev:1388
http://
Executed test runs:
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
Click here to trigger a rebuild:
http://
| PS Jenkins bot (ps-jenkins) wrote : | # |
FAILED: Continuous integration, rev:1391
http://
Executed test runs:
UNSTABLE: http://
UNSTABLE: http://
SUCCESS: http://
SUCCESS: http://
UNSTABLE: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
Click here to trigger a rebuild:
http://
| PS Jenkins bot (ps-jenkins) wrote : | # |
PASSED: Continuous integration, rev:1391
http://
Executed test runs:
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
Click here to trigger a rebuild:
http://
| Albert Astals Cid (aacid) wrote : | # |
I've triggered a rebuild, don't think the failures are because of this branch.
| Albert Astals Cid (aacid) wrote : | # |
Ha! That was bad timing. I've cancelled the rebuild :D
| PS Jenkins bot (ps-jenkins) wrote : | # |
FAILED: Continuous integration, rev:1391
http://
Executed test runs:
SUCCESS: http://
None: http://
SUCCESS: http://
SUCCESS: http://
None: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
Click here to trigger a rebuild:
http://
| Albert Astals Cid (aacid) wrote : | # |
And my cancelled build appears as failed :/
| PS Jenkins bot (ps-jenkins) wrote : | # |
PASSED: Continuous integration, rev:1391
http://
Executed test runs:
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
Click here to trigger a rebuild:
http://
| PS Jenkins bot (ps-jenkins) wrote : | # |
PASSED: Continuous integration, rev:1392
http://
Executed test runs:
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
Click here to trigger a rebuild:
http://
| Andrea Cimitan (cimi) wrote : | # |
I tested this few times in a row, until I found my launcher stuck 2px on screen when hidden (like always on screen 2px).
Might be some of the changes to Launcher.qml
another small thing, more a question, you added both chevron and tick png, but while for tick you used gridUnit, you used pixels for chevron... should both scale or not?
| Michael Terry (mterry) wrote : | # |
I'll look at the 2px-launcher problem.
As for gridUnit vs pixels... Arrow.qml mentions the size of the "chevron.png" source image in pixels, but for its actual height/width, it scales to whatever size the Arrow object is. So they both scale fine, I believe.
| Michael Terry (mterry) wrote : | # |
OK, fixed the launcher sometimes being left exposed. Thanks for the catch!
| Andrea Cimitan (cimi) wrote : | # |
* Did you perform an exploratory manual test run of the code change and any related functionality?
y
* Did CI run pass? If not, please explain why.
y
* Did you make sure that the branch does not contain spurious tags?
y
thanks, no issues I noticed now!
| PS Jenkins bot (ps-jenkins) wrote : | # |
FAILED: Continuous integration, rev:1393
http://
Executed test runs:
UNSTABLE: http://
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
UNSTABLE: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
Click here to trigger a rebuild:
http://
| Michael Terry (mterry) wrote : | # |
I'm going to wait to top-approve this, because design is still doing some minor tweaks (color tweaks, size of text, etc)
- 1395. By Michael Terry on 2015-01-09
-
Tweak colors of slider
| PS Jenkins bot (ps-jenkins) wrote : | # |
FAILED: Continuous integration, rev:1395
http://
Executed test runs:
FAILURE: http://
FAILURE: http://
FAILURE: http://
FAILURE: http://
FAILURE: http://
Click here to trigger a rebuild:
http://
- 1396. By Michael Terry on 2015-01-09
-
Merge from trunk
| PS Jenkins bot (ps-jenkins) wrote : | # |
FAILED: Continuous integration, rev:1396
http://
Executed test runs:
UNSTABLE: http://
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
UNSTABLE: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
Click here to trigger a rebuild:
http://
- 1397. By Michael Terry on 2015-01-15
-
Merge from trunk
| PS Jenkins bot (ps-jenkins) wrote : | # |
FAILED: Continuous integration, rev:1397
http://
Executed test runs:
UNSTABLE: http://
UNSTABLE: http://
SUCCESS: http://
SUCCESS: http://
UNSTABLE: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
Click here to trigger a rebuild:
http://
- 1398. By Michael Terry on 2015-01-28
-
Merge from trunk
| PS Jenkins bot (ps-jenkins) wrote : | # |
FAILED: Continuous integration, rev:1398
http://
Executed test runs:
UNSTABLE: http://
UNSTABLE: http://
SUCCESS: http://
SUCCESS: http://
UNSTABLE: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
Click here to trigger a rebuild:
http://
- 1399. By Michael Terry on 2015-02-01
-
Don't let user interact with launcher when not 'visible'
| PS Jenkins bot (ps-jenkins) wrote : | # |
FAILED: Continuous integration, rev:1399
http://
Executed test runs:
UNSTABLE: http://
UNSTABLE: http://
SUCCESS: http://
SUCCESS: http://
UNSTABLE: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
Click here to trigger a rebuild:
http://
- 1400. By Michael Terry on 2015-02-03
-
Update autopilot
| PS Jenkins bot (ps-jenkins) wrote : | # |
FAILED: Continuous integration, rev:1400
http://
Executed test runs:
FAILURE: http://
UNSTABLE: http://
SUCCESS: http://
SUCCESS: http://
FAILURE: http://
Click here to trigger a rebuild:
http://
| Michael Terry (mterry) wrote : | # |
OK, so this got updated with a couple minor design tweaks and a fix for the autopilot tests. Design has signed off on this version. And the autopilot passes now (well, you can't see it here yet -- I just kicked a rebuild, but you can see it in https:/
So I'm inclined to top-approve again if there isn't an objection.
| PS Jenkins bot (ps-jenkins) wrote : | # |
FAILED: Continuous integration, rev:1400
http://
Executed test runs:
UNSTABLE: http://
UNSTABLE: http://
SUCCESS: http://
SUCCESS: http://
UNSTABLE: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
Click here to trigger a rebuild:
http://
- 1401. By Michael Terry on 2015-02-05
-
Merge from trunk
- 1402. By Michael Terry on 2015-02-05
-
Fix tutorial qmluitests with the new lightdm mock
| PS Jenkins bot (ps-jenkins) wrote : | # |
PASSED: Continuous integration, rev:1400
http://
Executed test runs:
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
Click here to trigger a rebuild:
http://
- 1403. By Michael Terry on 2015-02-11
| PS Jenkins bot (ps-jenkins) wrote : | # |
PASSED: Continuous integration, rev:1402
http://
Executed test runs:
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
Click here to trigger a rebuild:
http://

FAILED: Continuous integration, rev:1371 jenkins. qa.ubuntu. com/job/ unity8- ci/4776/ jenkins. qa.ubuntu. com/job/ generic- deb-autopilot- utopic- touch/6263/ console jenkins. qa.ubuntu. com/job/ unity-phablet- qmluitests- utopic/ 1762 jenkins. qa.ubuntu. com/job/ unity8- utopic- amd64-ci/ 1872 jenkins. qa.ubuntu. com/job/ unity8- utopic- i386-ci/ 1870 jenkins. qa.ubuntu. com/job/ generic- deb-autopilot- runner- mako/5877/ console jenkins. qa.ubuntu. com/job/ generic- mediumtests- builder- utopic- armhf/7515 jenkins. qa.ubuntu. com/job/ generic- mediumtests- builder- utopic- armhf/7515/ artifact/ work/output/ *zip*/output. zip s-jenkins. ubuntu- ci:8080/ job/touch- flash-device/ 15144
http://
Executed test runs:
FAILURE: http://
UNSTABLE: http://
SUCCESS: http://
SUCCESS: http://
FAILURE: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
Click here to trigger a rebuild: s-jenkins. ubuntu- ci:8080/ job/unity8- ci/4776/ rebuild
http://