Merge lp:~mterry/unity8/tutorial-new-screens into lp:unity8
| Status: | Merged | ||||
|---|---|---|---|---|---|
| Approved by: | Michael Zanetti on 2015-02-04 | ||||
| Approved revision: | 1410 | ||||
| Merged at revision: | 1604 | ||||
| Proposed branch: | lp:~mterry/unity8/tutorial-new-screens | ||||
| Merge into: | lp:unity8 | ||||
| Prerequisite: | lp:~mterry/unity8/tutorial-refactor | ||||
| Diff against target: |
1549 lines (+769/-226) 16 files modified
qml/Shell.qml (+7/-3) qml/Stages/ApplicationWindow.qml (+14/-1) qml/Stages/PhoneStage.qml (+62/-34) qml/Stages/TransformedSpreadDelegate.qml (+27/-21) qml/Tutorial/Slider.qml (+8/-2) qml/Tutorial/Tick.qml (+29/-0) qml/Tutorial/Tutorial.qml (+8/-1) qml/Tutorial/TutorialBottom.qml (+104/-0) qml/Tutorial/TutorialBottomFinish.qml (+41/-0) qml/Tutorial/TutorialContent.qml (+69/-75) qml/Tutorial/TutorialLeftFinish.qml (+4/-10) qml/Tutorial/TutorialPage.qml (+79/-74) qml/Tutorial/TutorialRight.qml (+223/-0) tests/autopilot/unity8/shell/emulators/tutorial.py (+24/-4) tests/autopilot/unity8/shell/tests/test_tutorial.py (+7/-0) tests/qmltests/Tutorial/tst_Tutorial.qml (+63/-1) |
||||
| To merge this branch: | bzr merge lp:~mterry/unity8/tutorial-new-screens | ||||
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| PS Jenkins bot | continuous-integration | Approve on 2015-02-11 | |
| Michael Zanetti (community) | 2015-01-06 | Approve on 2015-02-04 | |
|
Review via email:
|
|||
Commit Message
Add new right-edge and bottom-edge screens to the first-boot edge tutorial
Description of the Change
Add new right-edge and bottom-edge screens to the first-boot edge tutorial.
I redesigned TutorialContent a bit to not use a loader, but pre-load everything. This prevented a delay between the Left and Right edge screens as it loads the fake app images. We already have a loader in Tutorial.qml, so I felt the second layer was unnecessary.
I also have added bits here and there to PhoneStage in order to support the right-edge tutorial screen.
Design spec here: https:/
To test, install the debs from this MP and run the following: phablet-config edges-intro --enable; adb reboot
== Checklist ==
* Are there any related MPs required for this MP to build/function as expected? Please list.
Yes, the pre-requisite linked to this MP
* Did you perform an exploratory manual test run of your code change and any related functionality?
Yes
* Did you make sure that your branch does not contain spurious tags?
Yes
* If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?
NA
* If you changed the UI, has there been a design review?
TBD
- 1394. By Michael Terry on 2015-01-07
-
Merge from refactor branch
- 1395. By Michael Terry on 2015-01-07
-
Robustify waiting for demoEdgesChanged signal by not doing it
| PS Jenkins bot (ps-jenkins) wrote : | # |
FAILED: Continuous integration, rev:1394
http://
Executed test runs:
SUCCESS: http://
UNSTABLE: http://
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
Click here to trigger a rebuild:
http://
| PS Jenkins bot (ps-jenkins) wrote : | # |
PASSED: Continuous integration, rev:1395
http://
Executed test runs:
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
Click here to trigger a rebuild:
http://
- 1396. By Michael Terry on 2015-01-07
-
Merge from -refactor branch
- 1397. By Michael Terry on 2015-01-07
-
Merge from -refactor
| PS Jenkins bot (ps-jenkins) wrote : | # |
FAILED: Continuous integration, rev:1397
http://
Executed test runs:
UNSTABLE: http://
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
UNSTABLE: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
Click here to trigger a rebuild:
http://
| PS Jenkins bot (ps-jenkins) wrote : | # |
FAILED: Continuous integration, rev:1397
http://
Executed test runs:
UNSTABLE: http://
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
UNSTABLE: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
Click here to trigger a rebuild:
http://
| Michael Zanetti (mzanetti) wrote : | # |
I tested the spread, still seems to work fine. I'm a bit worried that doing changes in the spread in the future might break the welcome wizard as its not totally obvious why your changes would be required if one only looks at the real right edge spread. I guess it would be beneficial to add some tests that verify your changes keep working. What do you think?
| PS Jenkins bot (ps-jenkins) wrote : | # |
FAILED: Continuous integration, rev:1397
http://
Executed test runs:
SUCCESS: http://
UNSTABLE: http://
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
Click here to trigger a rebuild:
http://
| MichaĆ Sawicz (saviq) wrote : | # |
There seem to be somewhat legitimate (if flaky) qmltest failures, please investigate.
| Albert Astals Cid (aacid) wrote : | # |
qmltestrunner.
- 1398. By Michael Terry on 2015-01-08
-
Merge from -refactor
- 1399. By Michael Terry on 2015-01-08
-
Add a couple tests
| Michael Terry (mterry) wrote : | # |
@mzanetti, I've added a test that pokes and prods some spread values to make sure that they are what we expect (like the first app delegate having x==shell.width instead of 0 for example).
It's hard to test the new spread mode fully because it modifies how the transforms are applied as mostly a visual thing. What I really want to be able to write is a "does it look right?" test, with maybe some Mike AI that knows the correct answer. But ah well. Checking some values will have to do for now.
| PS Jenkins bot (ps-jenkins) wrote : | # |
FAILED: Continuous integration, rev:1398
http://
Executed test runs:
UNSTABLE: http://
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
UNSTABLE: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
Click here to trigger a rebuild:
http://
| PS Jenkins bot (ps-jenkins) wrote : | # |
FAILED: Continuous integration, rev:1399
http://
Executed test runs:
UNSTABLE: http://
UNSTABLE: http://
SUCCESS: http://
SUCCESS: http://
UNSTABLE: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
Click here to trigger a rebuild:
http://
- 1400. By Michael Terry on 2015-01-09
-
Merge from -refactor
| PS Jenkins bot (ps-jenkins) wrote : | # |
FAILED: Continuous integration, rev:1400
http://
Executed test runs:
SUCCESS: http://
UNSTABLE: http://
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
Click here to trigger a rebuild:
http://
- 1401. By Michael Terry on 2015-01-09
-
Merge from -refactor
- 1402. By Michael Terry on 2015-01-09
-
Updated fake screenshots
- 1403. By Michael Terry on 2015-01-09
-
Merge from -refactor
| PS Jenkins bot (ps-jenkins) wrote : | # |
FAILED: Continuous integration, rev:1403
http://
Executed test runs:
UNSTABLE: http://
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
UNSTABLE: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
Click here to trigger a rebuild:
http://
- 1404. By Michael Terry on 2015-01-12
-
Update facebook.png from design
| PS Jenkins bot (ps-jenkins) wrote : | # |
FAILED: Continuous integration, rev:1404
http://
Executed test runs:
UNSTABLE: http://
FAILURE: http://
SUCCESS: http://
FAILURE: http://
UNSTABLE: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
Click here to trigger a rebuild:
http://
- 1405. By Michael Terry on 2015-01-15
-
Merge from -refactor
| PS Jenkins bot (ps-jenkins) wrote : | # |
FAILED: Continuous integration, rev:1405
http://
Executed test runs:
UNSTABLE: http://
UNSTABLE: http://
SUCCESS: http://
SUCCESS: http://
UNSTABLE: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
Click here to trigger a rebuild:
http://
| Albert Astals Cid (aacid) wrote : | # |
Text conflict in qml/Shell.qml
1 conflicts encountered.
- 1406. By Michael Terry on 2015-01-28
-
Merge from -refactor
| PS Jenkins bot (ps-jenkins) wrote : | # |
FAILED: Continuous integration, rev:1406
http://
Executed test runs:
UNSTABLE: http://
UNSTABLE: http://
SUCCESS: http://
SUCCESS: http://
UNSTABLE: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
Click here to trigger a rebuild:
http://
- 1407. By Michael Terry on 2015-01-30
-
Make spread pages slightly smaller
| PS Jenkins bot (ps-jenkins) wrote : | # |
FAILED: Continuous integration, rev:1407
http://
Executed test runs:
UNSTABLE: http://
FAILURE: http://
SUCCESS: http://
SUCCESS: http://
UNSTABLE: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
Click here to trigger a rebuild:
http://
- 1408. By Michael Terry on 2015-02-01
-
Merge from -refactor
- 1409. By Michael Terry on 2015-02-01
-
Add tease to bottom edge slider
| PS Jenkins bot (ps-jenkins) wrote : | # |
FAILED: Continuous integration, rev:1409
http://
Executed test runs:
UNSTABLE: http://
FAILURE: http://
SUCCESS: http://
SUCCESS: http://
UNSTABLE: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
Click here to trigger a rebuild:
http://
| Michael Zanetti (mzanetti) wrote : | # |
there's an outdated comment now, see inline comment
| Michael Terry (mterry) wrote : | # |
Naw, I think that comment is still fine. I replied inline. But I'm happy to change if you disagree.
| Michael Zanetti (mzanetti) wrote : | # |
* Did you perform an exploratory manual test run of the code change and any related functionality?
yes
* Did CI run pass? If not, please explain why.
no. ci seems to have crashed. I've just triggered a rebuild. Michael, please check if jenkins is fine with this branch before we land it.
* Did you make sure that the branch does not contain spurious tags?
yes
| PS Jenkins bot (ps-jenkins) wrote : | # |
FAILED: Continuous integration, rev:1409
http://
Executed test runs:
UNSTABLE: http://
UNSTABLE: http://
SUCCESS: http://
SUCCESS: http://
UNSTABLE: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
Click here to trigger a rebuild:
http://
| Michael Zanetti (mzanetti) wrote : | # |
ok, Jenkins built fine now. Failing qml tests don't seem to be related to this branch. However, Autopilot seems to have issues. I think at least this test is broken by this branch:
unity8.
Please also check if the other AP failures are related.
- 1410. By Michael Terry on 2015-02-03
-
Merge from -refactor
| PS Jenkins bot (ps-jenkins) wrote : | # |
FAILED: Continuous integration, rev:1410
http://
Executed test runs:
FAILURE: http://
UNSTABLE: http://
SUCCESS: http://
SUCCESS: http://
FAILURE: http://
Click here to trigger a rebuild:
http://
| Michael Terry (mterry) wrote : | # |
This is from Olga reviewing the latest code here:
"We reviewed the new implementation and you have the go ahead. :)
Looks brilliant! :D"
So that's a +1 from design. Just need to confirm fixed AP tests and we're good.
| PS Jenkins bot (ps-jenkins) wrote : | # |
FAILED: Continuous integration, rev:1410
http://
Executed test runs:
UNSTABLE: http://
UNSTABLE: http://
SUCCESS: http://
SUCCESS: http://
UNSTABLE: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
Click here to trigger a rebuild:
http://
- 1411. By Michael Terry on 2015-02-05
-
Merge from -refactor
- 1412. By Michael Terry on 2015-02-05
-
Merge from -refactor
| PS Jenkins bot (ps-jenkins) wrote : | # |
PASSED: Continuous integration, rev:1410
http://
Executed test runs:
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
Click here to trigger a rebuild:
http://
| PS Jenkins bot (ps-jenkins) wrote : | # |
FAILED: Continuous integration, rev:1412
http://
Executed test runs:
UNSTABLE: http://
UNSTABLE: http://
SUCCESS: http://
SUCCESS: http://
UNSTABLE: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
Click here to trigger a rebuild:
http://
- 1413. By Michael Terry on 2015-02-11
-
Merge from tutorial-refactor
| PS Jenkins bot (ps-jenkins) wrote : | # |
PASSED: Continuous integration, rev:1412
http://
Executed test runs:
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
Click here to trigger a rebuild:
http://

FAILED: Continuous integration, rev:1393 jenkins. qa.ubuntu. com/job/ unity8- ci/5080/ jenkins. qa.ubuntu. com/job/ generic- deb-autopilot- vivid-touch/ 676 jenkins. qa.ubuntu. com/job/ unity-phablet- qmluitests- vivid/244 jenkins. qa.ubuntu. com/job/ unity8- vivid-amd64- ci/245 jenkins. qa.ubuntu. com/job/ unity8- vivid-i386- ci/245 jenkins. qa.ubuntu. com/job/ generic- deb-autopilot- runner- vivid-mako/ 581 jenkins. qa.ubuntu. com/job/ generic- mediumtests- builder- vivid-armhf/ 674 jenkins. qa.ubuntu. com/job/ generic- mediumtests- builder- vivid-armhf/ 674/artifact/ work/output/ *zip*/output. zip s-jenkins. ubuntu- ci:8080/ job/touch- flash-device/ 16850
http://
Executed test runs:
SUCCESS: http://
UNSTABLE: http://
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
Click here to trigger a rebuild: s-jenkins. ubuntu- ci:8080/ job/unity8- ci/5080/ rebuild
http://