Merge lp:~mterry/unity8/tutorial-fixups into lp:unity8
| Status: | Merged |
|---|---|
| Approved by: | Daniel d'Andrada on 2016-05-20 |
| Approved revision: | 2365 |
| Merged at revision: | 2445 |
| Proposed branch: | lp:~mterry/unity8/tutorial-fixups |
| Merge into: | lp:unity8 |
| Diff against target: |
1339 lines (+289/-512) 14 files modified
qml/Components/Dialogs.qml (+3/-1) qml/Notifications/Notifications.qml (+1/-0) qml/Shell.qml (+12/-8) qml/Tutorial/InactivityTimer.qml (+32/-16) qml/Tutorial/Tutorial.qml (+7/-6) qml/Tutorial/TutorialBottom.qml (+0/-124) qml/Tutorial/TutorialContent.qml (+58/-141) qml/Tutorial/TutorialLeft.qml (+2/-2) qml/Tutorial/TutorialLeftLong.qml (+3/-1) qml/Tutorial/TutorialPage.qml (+2/-2) qml/Tutorial/TutorialRight.qml (+2/-2) qml/Tutorial/TutorialTop.qml (+2/-3) tests/qmltests/Tutorial/tst_Tutorial.qml (+165/-196) tests/qmltests/tst_Shell.qml (+0/-10) |
| To merge this branch: | bzr merge lp:~mterry/unity8/tutorial-fixups |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Unity8 CI Bot | continuous-integration | Approve on 2016-06-05 | |
| Daniel d'Andrada (community) | 2016-04-28 | Approve on 2016-05-20 | |
|
Review via email:
|
|||
Commit Message
Drop bottom edge tutorials completely and small fixes for other edges.
A bundle of fixes requested by Design, after living with the new tutorial for a while:
- Drop bottom edges completely. The existing in-app hints are enough, and we want to grow them rather than do it from shell. Plus they make the user interaction logic too complicated.
- Don't show any tutorials if a notification, dialog, or spread is already open.
- Left swipe:
* Delay for 20s (instead of immediately being shown)
* Specify "short" in text
- Top swipe:
* Delay for 60s (instead of 30s)
* Use "access to notifications and quick settings" (instead of "open notification bar")
- Long left swipe:
* Delay for 10s (instead of 5s) -- need to confirm with Design
* Move to after top swipe tutorial
* Only show if a non-dash app is focused
* Disable long left swipe in shell until this tutorial is shown
- Right swipe:
* Delay for 10s (instead of 3s)
* Require 3 apps to be open (instead of 2)
* Remove "short or long" from text
Description of the Change
* Are there any related MPs required for this MP to build/function as expected? Please list.
no
* Did you perform an exploratory manual test run of your code change and any related functionality?
Yes
* If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?
NA
* If you changed the UI, has there been a design review?
Yup, Paty is good with this (r2367)
| Daniel d'Andrada (dandrader) wrote : | # |
In qml/Tutorial/
"""
property bool paused // hide any existing tutorial and don't show new ones
property bool delayed // don't show new tutorials
"""
Looks like those two overlap or conflict a bit. Do all combinations make sense (paused && !delayed, paused && delayed, etc)?
Would it make more sense to combine those two (or more, like maybe even active) into a state or enumeration-like property?
- running (current active==true)
- paused (current active & paused)
- delayed (current active & delayed)
- off (current !active)
Also how does paused relate with the property below?
"""
readonly property bool running: loader.item ? loader.item.running : false
"""
Can it can be paused and running at the same time?
| Daniel d'Andrada (dandrader) wrote : | # |
Getting 8 failures and lots of binding loop warnings in tst_Tutorial.
| Daniel d'Andrada (dandrader) wrote : | # |
Did some basic testing on my mako. Works fine.
| Daniel d'Andrada (dandrader) wrote : | # |
Please update copyright headers (years) of:
qml/Components/
qml/Tutorial/
qml/Tutorial/
qml/Tutorial/
qml/Tutorial/
qml/Tutorial/
qml/Tutorial/
qml/Tutorial/
tests/qmltests/
- 2361. By Michael Terry on 2016-05-19
-
Merge from trunk
- 2362. By Michael Terry on 2016-05-19
-
Bump copyright years
- 2363. By Michael Terry on 2016-05-19
-
Fix tutorial tests
| Michael Terry (mterry) wrote : | # |
Yes, there's a good deal of overlap between paused and delayed. Basically paused is "super-delayed". It both delays and immediately stops any currently running tutorial. So just a more urgent delayed.
All combinations are fine and logical. But I agree that an enum would make more sense maybe. Unfortunately, qml best handles enums only if they're defined in C++ first. Otherwise, what? Strings? Kind of annoying.
I could also see changing it to a function call like stopAnyCurrentT
==
As for "running" -- that indicates if any tutorial is currently being shown (vs the tutorial in general being active, but just between tutorial pages).
==
I fixed the tests and the copyrights.
Thanks!
| Unity8 CI Bot (unity8-ci-bot) wrote : | # |
FAILED: Continuous integration, rev:2363
https:/
Executed test runs:
UNSTABLE: https:/
UNSTABLE: https:/
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
Click here to trigger a rebuild:
https:/
- 2364. By Michael Terry on 2016-05-20
-
Fix shell test; don't disable tutorial if we receive a call during the wizard
- 2365. By Michael Terry on 2016-05-20
-
Make a test more robust
| Unity8 CI Bot (unity8-ci-bot) wrote : | # |
FAILED: Continuous integration, rev:2365
https:/
Executed test runs:
UNSTABLE: https:/
UNSTABLE: https:/
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
Click here to trigger a rebuild:
https:/
| Daniel d'Andrada (dandrader) wrote : | # |
* Did you perform an exploratory manual test run of the code change and any related functionality?
Yes
* Did CI run pass? If not, please explain why.
No. Some unrelated failures.
- 2366. By Michael Terry on 2016-06-01
-
Merge from trunk
- 2367. By Michael Terry on 2016-06-02
-
And also don't start tutorial timers until the wizard is done
| Michael Terry (mterry) wrote : | # |
I've merged from trunk and made one tiny change -- we don't start tutorial timers until the wizard has finished. This means that the left edge tutorial waits the proper 20s after the wizard is done. I tested too often without bothering to re-enable the wizard. :P
Paty looked at this and said it's good. So all approved.
| Unity8 CI Bot (unity8-ci-bot) wrote : | # |
FAILED: Continuous integration, rev:2366
https:/
Executed test runs:
SUCCESS: https:/
UNSTABLE: https:/
UNSTABLE: https:/
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
Click here to trigger a rebuild:
https:/
| Unity8 CI Bot (unity8-ci-bot) wrote : | # |
PASSED: Continuous integration, rev:2366
https:/
Executed test runs:
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
Click here to trigger a rebuild:
https:/
- 2368. By Michael Terry on 2016-06-10
-
Merge from trunk

FAILED: Continuous integration, rev:2360 /unity8- jenkins. ubuntu. com/job/ lp-unity8- ci/1154/ /unity8- jenkins. ubuntu. com/job/ build-0- fetch/1547 /unity8- jenkins. ubuntu. com/job/ build-1- sourcepkg/ release= vivid+overlay/ 1507 /unity8- jenkins. ubuntu. com/job/ build-1- sourcepkg/ release= xenial+ overlay/ 1507 /unity8- jenkins. ubuntu. com/job/ build-2- binpkg/ arch=amd64, release= vivid+overlay/ 1507/console /unity8- jenkins. ubuntu. com/job/ build-2- binpkg/ arch=amd64, release= xenial+ overlay/ 1507 /unity8- jenkins. ubuntu. com/job/ build-2- binpkg/ arch=amd64, release= xenial+ overlay/ 1507/artifact/ output/ *zip*/output. zip /unity8- jenkins. ubuntu. com/job/ build-2- binpkg/ arch=armhf, release= vivid+overlay/ 1507 /unity8- jenkins. ubuntu. com/job/ build-2- binpkg/ arch=armhf, release= vivid+overlay/ 1507/artifact/ output/ *zip*/output. zip /unity8- jenkins. ubuntu. com/job/ build-2- binpkg/ arch=armhf, release= xenial+ overlay/ 1507 /unity8- jenkins. ubuntu. com/job/ build-2- binpkg/ arch=armhf, release= xenial+ overlay/ 1507/artifact/ output/ *zip*/output. zip /unity8- jenkins. ubuntu. com/job/ build-2- binpkg/ arch=i386, release= vivid+overlay/ 1507 /unity8- jenkins. ubuntu. com/job/ build-2- binpkg/ arch=i386, release= vivid+overlay/ 1507/artifact/ output/ *zip*/output. zip /unity8- jenkins. ubuntu. com/job/ build-2- binpkg/ arch=i386, release= xenial+ overlay/ 1507/console
https:/
Executed test runs:
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
FAILURE: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
FAILURE: https:/
Click here to trigger a rebuild: /unity8- jenkins. ubuntu. com/job/ lp-unity8- ci/1154/ rebuild
https:/