Merge lp:~mterry/unity8/tutorial-edge-size into lp:unity8
| Status: | Merged |
|---|---|
| Approved by: | Albert Astals Cid on 2015-02-23 |
| Approved revision: | 1618 |
| Merged at revision: | 1645 |
| Proposed branch: | lp:~mterry/unity8/tutorial-edge-size |
| Merge into: | lp:unity8 |
| Diff against target: |
21 lines (+2/-2) 1 file modified
qml/Tutorial/TutorialRight.qml (+2/-2) |
| To merge this branch: | bzr merge lp:~mterry/unity8/tutorial-edge-size |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Albert Astals Cid (community) | 2015-02-18 | Approve on 2015-02-23 | |
| PS Jenkins bot | continuous-integration | Needs Fixing on 2015-02-19 | |
|
Review via email:
|
|||
Commit Message
Make the draggable part of the right edge (during the tutorial) a constant size, instead of having it grow and shrink as the spread peeks out from the side.
Description of the Change
Make the draggable part of the right edge (during the tutorial) a constant size, instead of having it grow and shrink as the spread peeks out from the side.
I believe this was the original intention, but looks like I messed up the logic.
== Checklist ==
* Are there any related MPs required for this MP to build/function as expected? Please list.
No
* Did you perform an exploratory manual test run of your code change and any related functionality?
Yes. I made the drag area yellow and tested both situations. Plus, you can test a little with your finger, but it's harder to be confident that way.
* Did you make sure that your branch does not contain spurious tags?
Yes
* If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?
NA
* If you changed the UI, has there been a design review?
NA
| PS Jenkins bot (ps-jenkins) wrote : | # |
FAILED: Continuous integration, rev:1618
http://
Executed test runs:
UNSTABLE: http://
UNSTABLE: http://
SUCCESS: http://
SUCCESS: http://
UNSTABLE: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
Click here to trigger a rebuild:
http://
| Albert Astals Cid (aacid) wrote : | # |
* Did you perform an exploratory manual test run of the code change and any related functionality?
Yes
* Did CI run pass?
No, known broken tests
* Did you make sure that the branch does not contain spurious tags?
Yes

FAILED: Continuous integration, rev:1618 jenkins. qa.ubuntu. com/job/ unity8- ci/5342/ jenkins. qa.ubuntu. com/job/ generic- deb-autopilot- vivid-touch/ 1428 jenkins. qa.ubuntu. com/job/ unity-phablet- qmluitests- vivid/506 jenkins. qa.ubuntu. com/job/ unity8- vivid-amd64- ci/507 jenkins. qa.ubuntu. com/job/ unity8- vivid-i386- ci/507/ console jenkins. qa.ubuntu. com/job/ generic- deb-autopilot- runner- vivid-mako/ 1264 jenkins. qa.ubuntu. com/job/ generic- mediumtests- builder- vivid-armhf/ 1426 jenkins. qa.ubuntu. com/job/ generic- mediumtests- builder- vivid-armhf/ 1426/artifact/ work/output/ *zip*/output. zip s-jenkins. ubuntu- ci:8080/ job/touch- flash-device/ 18179
http://
Executed test runs:
UNSTABLE: http://
UNSTABLE: http://
SUCCESS: http://
FAILURE: http://
UNSTABLE: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
Click here to trigger a rebuild: s-jenkins. ubuntu- ci:8080/ job/unity8- ci/5342/ rebuild
http://