Merge lp:~mterry/unity8/tutorial-edge-size into lp:unity8

Proposed by Michael Terry on 2015-02-18
Status: Merged
Approved by: Albert Astals Cid on 2015-02-23
Approved revision: 1618
Merged at revision: 1645
Proposed branch: lp:~mterry/unity8/tutorial-edge-size
Merge into: lp:unity8
Diff against target: 21 lines (+2/-2)
1 file modified
qml/Tutorial/TutorialRight.qml (+2/-2)
To merge this branch: bzr merge lp:~mterry/unity8/tutorial-edge-size
Reviewer Review Type Date Requested Status
Albert Astals Cid (community) 2015-02-18 Approve on 2015-02-23
PS Jenkins bot continuous-integration Needs Fixing on 2015-02-19
Review via email: mp+250220@code.launchpad.net

Commit Message

Make the draggable part of the right edge (during the tutorial) a constant size, instead of having it grow and shrink as the spread peeks out from the side.

Description of the Change

Make the draggable part of the right edge (during the tutorial) a constant size, instead of having it grow and shrink as the spread peeks out from the side.

I believe this was the original intention, but looks like I messed up the logic.

== Checklist ==

 * Are there any related MPs required for this MP to build/function as expected? Please list.
 No

 * Did you perform an exploratory manual test run of your code change and any related functionality?
 Yes. I made the drag area yellow and tested both situations. Plus, you can test a little with your finger, but it's harder to be confident that way.

 * Did you make sure that your branch does not contain spurious tags?
 Yes

 * If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?
 NA

 * If you changed the UI, has there been a design review?
 NA

To post a comment you must log in.
Albert Astals Cid (aacid) wrote :

 * Did you perform an exploratory manual test run of the code change and any related functionality?
Yes

 * Did CI run pass?
No, known broken tests

 * Did you make sure that the branch does not contain spurious tags?
Yes

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'qml/Tutorial/TutorialRight.qml'
2--- qml/Tutorial/TutorialRight.qml 2015-01-30 14:23:23 +0000
3+++ qml/Tutorial/TutorialRight.qml 2015-02-18 21:34:52 +0000
4@@ -42,7 +42,7 @@
5 UbuntuNumberAnimation {
6 target: stage
7 property: "x"
8- to: -stage.dragAreaOverlap
9+ to: -units.gu(2)
10 duration: UbuntuAnimation.SleepyDuration
11 }
12 UbuntuNumberAnimation {
13@@ -82,7 +82,7 @@
14 focusFirstApp: false
15 startScale: 0.8
16 endScale: 0.6
17- dragAreaOverlap: units.gu(2)
18+ dragAreaOverlap: -x
19
20 onOpened: {
21 overlay.show();

Subscribers

People subscribed via source and target branches