Code review comment for lp:~mterry/unity8/split

Revision history for this message
MichaƂ Sawicz (saviq) wrote :

I get 3 users after the accountsservice upgrade: phablet, radio and system.

=====

No launcher in greeter on any of the 3 devices I have.

=====

Indicators in session don't get dismissed on suspend.

=====

"Tap to unlock" string only shows after some input in greeter after locking.

=====

Volume doesn't sync from greeter to session (should it?).

=====

Location/Bluetooth don't sync between greeter and session (should it?).

=====

Three batteries on manta in greeter "Battery" indicator.

=====

SIM unlock in greeter is not fullscreen (different to bug #1308011).
http://people.canonical.com/~msawicz/unity8/pin_good.png
vs.
http://people.canonical.com/~msawicz/unity8/pin_bad.png

=====

Alarm icon isn't shown in greeter (related to bug #1317861).

=====

Volume buttons don't work in greeter.

=====

Shouldn't we now drop the password from the phablet user if we want it to be unlocked, and support setting a password via passwd, and enforce it?

=====

Can't verify password-protected functionality.

=====

Trunk issues for reference:
- greeter strings are not translated
- "Swipe to unlock" conflicts with the user chooser - the user chooser should probably be made smaller
- timed-out SIM lock causes input to be blocked altogether
- SIM lock doesn't prevent you from interacting with indicators in greeter
- I can tap through the edge demo in the greeter, select different users and type a password in.
- Multi-user phone looks BAD - mini infographics. I thought we prevented multi-user on phone until we had designs?
- lockscreen isn't used any more after launching an app from greeter launcher (can't confirm with split as there's no launcher any more, or being able to password-protect the account)

review: Needs Fixing

« Back to merge proposal