Code review comment for lp:~mterry/unity8/split

As for all the manta oddities, I can't reproduce on a recent image. You said you tested on an old image. If you test on new one, do you see the crashes and extra battery icons?

I fixed the Tap to Unlock animation not happening in this branch. And I fixed the "session is black if an app is up" with a unity-mir branch [1].

We both confirmed that launcher kicking in a second time is in trunk.

As for locale, I've fixed what you saw. I was exporting language, but not locale. Note that you still need to reboot for the change to take effect, but that's an existing bug with the shell. So there's no regression there.

You mention language in a multi-user situation (switching greeter languages when user switches). This is another open design question. The current design (on the desktop) is that the greeter just uses the system language and doesn't switch languages. Which unity8-greeter does too. But I've added a little hack in unity8-greeter-wrapper that notices if we have a phablet user with uid 32011 and sets language (and now locale) to that user's settings if so.

FYI, the "not syncing clears of indicator messages" is bug 1317649. Ted is on it.

So the only remaining regression by my count is SIM unlocking. Which I'll need your help with. Can we sync up tomorrow about it?

Also, I've just noticed that we flash the user session for a frame or two during boot on manta. I'll look at that, but it's likely an off-by-one frame bug in the USC branches, not this branch.

[1] https://code.launchpad.net/~mterry/unity-mir/dont-hide-focused-apps/+merge/220130