Unity 8

Code review comment for lp:~mterry/unity8/split

split
Merge into trunk

Revision history for this message

Michael Terry (mterry) wrote on 2014-03-25:

- Made unity8-greeter Depend on libglib2.0-bin
- Dropped extra qgetenv call in AccountsService constructor
- Removed extra headers from URLDispatcher.cpp
- Switched to <QtQml/qqml.h>
- Dropped m_parent from URLDispatcherInterface
- Dropped m_broadcaster(NULL)
- Removed tests/autopilot/unity8/shell/tests/test_greeter.py.THIS

- Yeah, it's expected that ./run no longer gives greeter. And if you want to use mocks with -G, you need to also pass -f, like ./run -fG

- So the deal with demoEdgesForCurrentUser and demoEdges. The AccountsService plugin as a whole points at a single user for its various values (statsWelcomeScreen, backgroundFile, etc). When in the session, we want that to be the current user ($USER). In the greeter, that will be whomever is selected in the greeter (think multi-user case). So that's why m_user defaults to $USER but is changeable. But consider the case of the edge demo. There is a greeter component to that and a user session component. The greeter decides to show its edge demo based on the lightdm user's field. But if the user skips the demo from the greeter, the greeter needs to set the user's edge demo field to false too, so the user doesn't see it once they log in. So I added a special member variable demoEdgesForCurrentUser that always tracks the current user that the greeter could use for its own demo decision and it could continue using demoEdges to set the user's demo field to false if it wanted to. That's why they are completely separate fields.

- tests/qmltests/CMakeLists.txt has all those changes because of the change in qml/Components/PageHeader.qml. It needed to start using the SessionManager plugin (to reset search when screen is locked). So any test using it needed to start using the mock plugin search path. And looking through the tests, almost every test either already had the binary plugin dir manually specified or would need it because of this change. So I added it to the default includes for tests. And that let me clean up nearly all the test calls to not need manually specified paths.

- test_searchIndicatorHidesOnGreeterShown has no replacement because it doesn't make sense anymore. In greeter, the search indicator is never shown. And in the session, when the session is locked, it doesn't care about hiding the search indicator since it doesn't share a panel with the greeter anymore.

- I'm not sure why nothing showed up for you on reboot. Except maybe you didn't rebuild the various packages depending on Mir 0.1.18 (platform-api, unity-mir)? It might be easiest to use the PPA we're using for testing: https://launchpad.net/~ci-train-ppa-service/+archive/landing-004

- Yeah, it's expected that ./run no longer gives greeter.  And if you want to use mocks with -G, you need to also pass -f, like ./run -fG

- So the deal with demoEdgesForCurrentUser and demoEdges.  The AccountsService plugin as a whole points at a single user for its various values (statsWelcomeScreen, backgroundFile, etc).  When in the session, we want that to be the current user ($USER).  In the greeter, that will be whomever is selected in the greeter (think multi-user case).  So that's why m_user defaults to $USER but is changeable.  But consider the case of the edge demo.  There is a greeter component to that and a user session component.  The greeter decides to show its edge demo based on the lightdm user's field.  But if the user skips the demo from the greeter, the greeter needs to set the user's edge demo field to false too, so the user doesn't see it once they log in.  So I added a special member variable demoEdgesForCurrentUser that always tracks the current user that the greeter could use for its own demo decision and it could continue using demoEdges to set the user's demo field to false if it wanted to.  That's why they are completely separate fields.

- tests/qmltests/CMakeLists.txt has all those changes because of the change in qml/Components/PageHeader.qml.  It needed to start using the SessionManager plugin (to reset search when screen is locked).  So any test using it needed to start using the mock plugin search path.  And looking through the tests, almost every test either already had the binary plugin dir manually specified or would need it because of this change.  So I added it to the default includes for tests.  And that let me clean up nearly all the test calls to not need manually specified paths.

- test_searchIndicatorHidesOnGreeterShown has no replacement because it doesn't make sense anymore.  In greeter, the search indicator is never shown.  And in the session, when the session is locked, it doesn't care about hiding the search indicator since it doesn't share a panel with the greeter anymore.

- I'm not sure why nothing showed up for you on reboot.  Except maybe you didn't rebuild the various packages depending on Mir 0.1.18 (platform-api, unity-mir)?  It might be easiest to use the PPA we're using for testing: https://launchpad.net/~ci-train-ppa-service/+archive/landing-004

« Back to merge proposal