Unity 8

Code review comment for lp:~mterry/unity8/split

  1. split
  2. Merge into trunk
Revision history for this message
Albert Astals Cid (aacid) wrote :

Do you really need m_parent in URLDispatcherInterface ? I mean you're forcing the URLDispatcherInterface constructor to get a URLDispatcher *parent parameter that you pass down to QObject so we could just save the m_parent pointer and in ::DispatchURL just do static_cast<URLDispatcher *>(parent()), no?

review: Needs Information

« Back to merge proposal