Merge lp:~mterry/unity8/sourceSizeBackground into lp:unity8

[Michael Terry]

Limit how much memory we reserve for the greeter background image, allowing giant images to appear correctly.

The downside is that even if the image is smaller, we'll still reserve the whole screen size in memory. But we avoid the actual bug anyway.

Limit how much memory we reserve for the greeter background image, allowing giant images to appear correctly.

The downside is that even if the image is smaller, we'll still reserve the whole screen size in memory. But we avoid the actual bug anyway.

== Checklist ==

 * Are there any related MPs required for this MP to build/function as expected? Please list.
 No

 * Did you perform an exploratory manual test run of your code change and any related functionality?
 Yes

 * Did you make sure that your branch does not contain spurious tags?
 Yes

 * If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?
 NA

 * If you changed the UI, has there been a design review?
 NA

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:1290
http://jenkins.qa.ubuntu.com/job/unity8-ci/4406/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-utopic-touch/5204/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-utopic/1402/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity8-utopic-amd64-ci/1500/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity8-utopic-i386-ci/1500/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/6456/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/4406/rebuild

review: Needs Fixing (continuous-integration)

[Michael Zanetti (mzanetti)]

lgtm

 * Did you perform an exploratory manual test run of the code change and any related functionality?

yes

 * Did CI run pass? If not, please explain why.

distro broken atm :/

review: Approve

[Michał Sawicz (saviq)]

FWIW this isn't the correct fix. This will scale the image down to *fit* within a box defined by sourceSize. So if you have a landscape wallpaper displayed on a portrait phone, it will be scaled down to fit within the width and then scaled up again on the GPU and cropped to fill the phone.

[Michał Sawicz (saviq)]

This is really an Image component limitation (will file a QTBUG soon), but here's a workaround we applied on the scope results, that could be used here as well ~unity-team/unity8/croppedImageMinimumSourceSize.

=== modified file 'qml/Greeter/GreeterContent.qml'
--- qml/Greeter/GreeterContent.qml	2014-08-19 12:55:10 +0000
+++ qml/Greeter/GreeterContent.qml	2014-09-25 18:36:59 +0000
@@ -47,6 +47,9 @@
             topMargin: backgroundTopMargin
         }
         fillMode: Image.PreserveAspectCrop
+        // Limit how much memory we'll reserve for this image
+        sourceSize.height: height
+        sourceSize.width: width
     }
 
     // See Shell.qml's backgroundSettings treatment for why we need a separate