Merge lp:~mterry/unity8/no-shutdown-dialog-while-suspended into lp:unity8

[Michael Terry]

Don't show any power dialogs while the screen is off. This is a band-aid to avoid the symptom, while we still investigate the source of why the screen doesn't turn on (and why we seem to not handle the power-button-release event).

Don't show any power dialogs while the screen is off.

From the code:

// FIXME: We only consider power key presses if the screen is
// on because of bug 1410830. The theory is that when that bug
// is encountered, there is a >2s delay between the power press
// event and the power release event, which causes the shutdown
// dialog to appear on resume. So to avoid that symptom while
// we investigate the root cause, we simply won't initiate any
// dialogs when the screen is off.

So to be clear, this is a band-aid to avoid the symptom, while we still investigate the source of why the screen doesn't turn on (and why we seem to not handle the power-button-release event).

To make it worse, this bug is hard to reproduce. I'm not even really sure this band-aid fixes the symptom. But it seems like it would. So that's basically the same, right!?

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:1546
http://jenkins.qa.ubuntu.com/job/unity8-ci/5147/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/804
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-vivid/311
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-vivid-amd64-ci/312
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-vivid-i386-ci/312
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-vivid-mako/700
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/802
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/802/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/17078

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/5147/rebuild

review: Needs Fixing (continuous-integration)

[kevin gunn (kgunn72)]

this was tested by rick against jibel's repro method many times - this fix corrected that
since rick has the magic handset & user mojo he is currently testing his roaming-test, so far so good, testing overnight as well.

[Michael Terry (mterry)]

<kgunn> mterry: so rick said he never saw the poweroff dialog, but did experience the busy/slow resume

So that seems promising.

[lp:~mterry/unity8/no-shutdown-dialog-while-suspended]

1547. By Michael Terry on 2015-01-15

Reference Rick's bug too

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:1547
http://jenkins.qa.ubuntu.com/job/unity8-ci/5152/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/825
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-vivid/316
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-vivid-amd64-ci/317
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-vivid-i386-ci/317
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-vivid-mako/720
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/823
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/823/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/17126

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/5152/rebuild

review: Needs Fixing (continuous-integration)

[Gerry Boland (gerboland)]

I can't reproduce this, but as other people can, the fix is logical

review: Approve

[lp:~mterry/unity8/no-shutdown-dialog-while-suspended]

1548. By Michael Terry on 2015-01-21

Merge from trunk

=== modified file 'qml/Shell.qml'
--- qml/Shell.qml	2015-01-09 10:41:41 +0000
+++ qml/Shell.qml	2015-01-21 14:43:33 +0000
@@ -181,7 +181,16 @@
     WindowKeysFilter {
         Keys.onPressed: {
             if (event.key == Qt.Key_PowerOff || event.key == Qt.Key_PowerDown) {
-                dialogs.onPowerKeyPressed();
+                // FIXME: We only consider power key presses if the screen is
+                // on because of bugs 1410830/1409003.  The theory is that when
+                // those bugs are encountered, there is a >2s delay between the
+                // power press event and the power release event, which causes
+                // the shutdown dialog to appear on resume.  So to avoid that
+                // symptom while we investigate the root cause, we simply won't
+                // initiate any dialogs when the screen is off.
+                if (Powerd.status === Powerd.On) {
+                    dialogs.onPowerKeyPressed();
+                }
                 event.accepted = true;
             } else {
                 volumeKeyFilter.onKeyPressed(event.key);