Unity 8

Merge lp:~mterry/unity8/no-hardcoded-password into lp:unity8

Proposed by Michael Terry on 2014-07-28

Status:	Merged
Approved by:	Michał Sawicz on 2014-08-05
Approved revision:	1087
Merged at revision:	1127
Proposed branch:	lp:~mterry/unity8/no-hardcoded-password
Merge into:	lp:unity8
Diff against target:	28 lines (+1/-3) 1 file modified run_on_device.sh (+1/-3)
To merge this branch:	bzr merge lp:~mterry/unity8/no-hardcoded-password
Related bugs:	Link a bug report

Reviewer	Review Type	Date Requested	Status
PS Jenkins bot (community)	continuous-integration		Needs Fixing on 2014-08-06
Michał Sawicz		2014-07-28	Approve on 2014-08-05
Review via email: mp+228546@code.launchpad.net

Don't hardcode the phablet password in our testing script.

Don't hardcode the phablet password in our testing script.

With the ability to set your own password, hardcoding a password will fail. It was probably never best practice anyway. :)

== Checklist ==

* Are there any related MPs required for this MP to build/function as expected? Please list.
- No

* Did you perform an exploratory manual test run of your code change and any related functionality?
- Yes

* Did you make sure that your branch does not contain spurious tags?
- Yes

* If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?
- NA

* If you changed the UI, has there been a design review?
- NA

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-07-29:

review: Needs Fixing (continuous-integration)

Revision history for this message

Michał Sawicz (saviq) wrote on 2014-08-05:

* Did you perform an exploratory manual test run of the code change and any related functionality?
Yeah, works.

* Did CI run pass? If not, please explain why.
Unrelated, known failure.

review: Approve

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-08-06:

review: Needs Fixing (continuous-integration)

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk

People subscribed via source and target branches

to all changes:

1	=== modified file 'run_on_device.sh'
2	--- run_on_device.sh 2014-05-14 17:37:16 +0000
3	+++ run_on_device.sh 2014-07-28 17:43:20 +0000
4	@@ -2,7 +2,6 @@
5	CODE_DIR=shell
6	USER=phablet
7	USER_ID=32011
8	-PASSWORD=phablet
9	PACKAGE=unity8
10	BINARY=unity8
11	TARGET_IP=${TARGET_IP-127.0.0.1}
12	@@ -13,7 +12,6 @@
13	GDB=false
14	PINLOCK=false
15	KEYLOCK=false
16	-SUDO="echo $PASSWORD \| sudo -S"
17	NUM_JOBS='$(( `grep -c ^processor /proc/cpuinfo` + 1 ))'
18	FLIPPED=false
19	CHROOT_PREFIX="/data/ubuntu"
20	@@ -76,7 +74,7 @@
21
22	install_dependencies() {
23	exec_with_adb apt-get update
24	- exec_with_ssh $SUDO apt-get -y install build-essential rsync bzr ccache gdb ninja-build devscripts equivs unity-plugin-scopes
25	+ exec_with_adb apt-get -y --force-yes install build-essential rsync bzr ccache gdb ninja-build devscripts equivs unity-plugin-scopes
26	}
27
28	sync_code() {